Page MenuHomePhabricator

[DebugInfo] Add test cases for generating debug info of labels.
AbandonedPublic

Authored by HsiangKai on Mar 29 2018, 7:19 AM.

Details

Reviewers
rnk
chenwj

Diff Detail

Repository
rL LLVM

Event Timeline

HsiangKai created this revision.Mar 29 2018, 7:19 AM
chenwj requested changes to this revision.Mar 30 2018, 5:50 AM

I think the test case should be a general one, not relate to any particular target.

test/DebugInfo/debuglabel.ll
1

test/DebugInfo/Generic/ would be a better place for this test case.

43

Better check other test cases, I don't think this generic case should have target-dependent parts.

This revision now requires changes to proceed.Mar 30 2018, 5:50 AM
probinson added inline comments.
test/DebugInfo/debuglabel.ll
6

Generally we don't use SAME unless the line is getting long; I know I would find it easier to read these as one line:
CHECK-NEXT: DW_AT_name [DW_FORM_strp] {{.*}} "top"

25

You could put a space before the regex and remove the [[:space:]] to make these more readable.

HsiangKai abandoned this revision.Apr 12 2018, 1:17 AM

Merged into D45556.