User Details
- User Since
- Oct 27 2014, 5:21 AM (325 w, 3 d)
Apr 3 2018
Nitpick.
Mar 30 2018
I am not sure which fields of DILabel are required or optional, please double check yourself. I also feel bitcode patch can be combined with llvm assembly patch.
LGTM. However, combining this one with D45025 would be better.
Nit.
I don't understand the part of BasicBlock, the others LGTM.
Nits.
I think the test case should be a general one, not relate to any particular target.
Mar 27 2018
@sdardis I have no commit access. Please commit it for me, thanks.
Mar 24 2018
Feb 12 2018
@kparzysz ping?
Feb 5 2018
@kparzysz Could you commit this for me? Thanks!
Feb 1 2018
Comment inline.
Jan 24 2018
I have one minor concern, please see the inline comment.
Jan 23 2018
I think this field is useful for most targets. Just a little concern about the coding style.
@theraven Could you commit this for me? I will be happy to update the context if I have more experience on this.
Jan 22 2018
@theraven, ping?
Jan 18 2018
@theraven For `libunwind` part, I am not sure if it's okay to include your link there. I just skim through the patch and list the key points I thought.
Jan 17 2018
Jul 21 2017
@dblaikie Done. I need your help here since I don't have commit access. Thanks. :)
@dblaikie ping? :-)
Jul 20 2017
Jul 19 2017
@dblaikie Done.
@dblaikie I upload the profile data and test case. However, the error message I check including the full path of the profile data. Any idea on how can I improve this?
address review comment.
Jul 18 2017
Jun 30 2017
Jun 26 2017
Jun 18 2017
May 23 2017
@kparzysz please help me commit it as I have no commit access, thanks.
May 22 2017
May 21 2017
May 20 2017
May 17 2017
@grosser I add you as reviewer because you once responded my mail [1].
May 16 2017
@dberris Thanks for the info!
May 11 2017
Add more example.
May 10 2017
May 8 2017
May 5 2017
@erichkeane Just share what I investigated.
@eli.friedman I find you added isObjCObjectType check in svn revision 184006 (git commit ddb5a392). Could you confirm returning zero rather than true here is okay? A little explanation would be even better. Thanks.
The GettingStarted.rst already been updated.
@t.p.northover Ping? :-)
May 4 2017
I have no right to commit, need someone's help. :-)
@kparzysz There are two places I think using auto should be okay, replacing other auto with type.
@kparzysz All done. :-)
May 3 2017
@spatel I update the code. please take a look, thanks. :-)
Use SDep & or const SDep & rather than auto.
Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m (line 11). I ran the lit tests initially with a breakpoint on this line and it never hit, though I must have set up the debugger wrong. Once I replaced it with an assert, method-bad-param failed.
May 2 2017
Apr 30 2017
Apr 28 2017
@wenbos Could you explain why moving GetNumNodeResults up ahead solves the problem? I see one problem is Operator will be changed if it's SubClassOf("Intrinsic"), that might make GetNumNodeResults return the wrong result. I don't know if your patch is the right fix, although it works.
Apr 27 2017
@asb And you? :-)
I don't have commit access, need your help. ;-)
Address review comments.
Apr 24 2017
Apr 19 2017
Ping? Any comment? :-)
Apr 16 2017
Apr 13 2017
I don't have commit access, need someone's help. :-)
Apr 3 2017
I don't have commit access, need someone's help.
Apr 2 2017
Mar 29 2017
I don't have commit access, need someone's help.