Page MenuHomePhabricator

chenwj (Wei-Ren Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 27 2014, 5:21 AM (267 w, 1 d)

Recent Activity

Apr 3 2018

chenwj added a comment to D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label..

I guess this fixes https://llvm.org/PR36420?

Apr 3 2018, 4:05 PM
chenwj added a comment to D45024: [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label..

Nitpick.

Apr 3 2018, 6:56 AM

Mar 30 2018

chenwj added a comment to D45026: [DebugInfo] Add bitcode reader/writer for DILabel metadata..

I am not sure which fields of DILabel are required or optional, please double check yourself. I also feel bitcode patch can be combined with llvm assembly patch.

Mar 30 2018, 8:00 AM
chenwj added a comment to D45032: [DebugInfo] LLVM IR assembly writer for DILabel..

LGTM. However, combining this one with D45025 would be better.

Mar 30 2018, 7:47 AM
chenwj requested changes to D45025: [DebugInfo] Add parser for DILabel metadata..

Nit.

Mar 30 2018, 7:32 AM
chenwj added a comment to D45078: [DebugInfo] Enable the capability of attaching metadata to BasicBlock..

I don't understand the part of BasicBlock, the others LGTM.

Mar 30 2018, 7:21 AM
chenwj requested changes to D45045: [DebugInfo] Generate debug information for labels..

Nits.

Mar 30 2018, 6:23 AM
chenwj requested changes to D45043: [DebugInfo] Add test cases for generating debug info of labels..

I think the test case should be a general one, not relate to any particular target.

Mar 30 2018, 5:50 AM

Mar 27 2018

chenwj added a comment to D44867: [Mips] Remove dead code.

@sdardis I have no commit access. Please commit it for me, thanks.

Mar 27 2018, 6:49 AM

Mar 24 2018

chenwj created D44867: [Mips] Remove dead code.
Mar 24 2018, 9:09 AM

Feb 12 2018

chenwj added a comment to D42905: [NFC] Fix comment of class InstrStage.

@kparzysz ping?

Feb 12 2018, 5:30 AM

Feb 5 2018

chenwj added a comment to D42905: [NFC] Fix comment of class InstrStage.

@kparzysz Could you commit this for me? Thanks!

Feb 5 2018, 3:43 PM
chenwj added a reviewer for D42905: [NFC] Fix comment of class InstrStage: kparzysz.
Feb 5 2018, 5:33 AM
chenwj created D42905: [NFC] Fix comment of class InstrStage.
Feb 5 2018, 5:29 AM

Feb 1 2018

chenwj added a comment to D42782: [RISCV] Fix c.addi and c.addi16sp immediate constraints which should be non-zero.

Comment inline.

Feb 1 2018, 5:56 AM

Jan 24 2018

chenwj added a comment to D42465: [RFC][CallingConv] Add CCAssignToRegWithType Calling Convention Interface.

I have one minor concern, please see the inline comment.

Jan 24 2018, 4:57 AM

Jan 23 2018

chenwj added a comment to D42374: [RFC] Add IsFixed field to ISD::ArgFlagsTy.

I think this field is useful for most targets. Just a little concern about the coding style.

Jan 23 2018, 5:13 AM
chenwj added a comment to D42178: [Doc] Guideline on adding exception handling support for a target.

@theraven Could you commit this for me? I will be happy to update the context if I have more experience on this.

Jan 23 2018, 4:51 AM

Jan 22 2018

chenwj added a comment to D42178: [Doc] Guideline on adding exception handling support for a target.

@theraven, ping?

Jan 22 2018, 5:21 AM

Jan 18 2018

chenwj updated the diff for D42178: [Doc] Guideline on adding exception handling support for a target.

@theraven For `libunwind` part, I am not sure if it's okay to include your link there. I just skim through the patch and list the key points I thought.

Jan 18 2018, 7:56 AM

Jan 17 2018

chenwj created D42178: [Doc] Guideline on adding exception handling support for a target.
Jan 17 2018, 6:28 AM

Jul 21 2017

chenwj updated the diff for D35586: [ProfData] Detect if zlib is available .

@dblaikie Done. I need your help here since I don't have commit access. Thanks. :)

Jul 21 2017, 1:54 PM
chenwj added a comment to D35586: [ProfData] Detect if zlib is available .

@dblaikie ping? :-)

Jul 21 2017, 6:05 AM

Jul 20 2017

chenwj added inline comments to D35586: [ProfData] Detect if zlib is available .
Jul 20 2017, 3:43 AM

Jul 19 2017

chenwj updated the diff for D35586: [ProfData] Detect if zlib is available .

@dblaikie Done.

Jul 19 2017, 4:06 PM
chenwj updated the diff for D35586: [ProfData] Detect if zlib is available .

@dblaikie I upload the profile data and test case. However, the error message I check including the full path of the profile data. Any idea on how can I improve this?

Jul 19 2017, 2:35 PM
chenwj added a comment to D35586: [ProfData] Detect if zlib is available .

Test case?

Jul 19 2017, 8:36 AM
chenwj updated the diff for D35586: [ProfData] Detect if zlib is available .

address review comment.

Jul 19 2017, 3:05 AM

Jul 18 2017

chenwj created D35586: [ProfData] Detect if zlib is available .
Jul 18 2017, 4:17 PM

Jun 30 2017

chenwj added a comment to D34856: Let llvm-diff correctly deal with Undef/ConstantAggregateZero/ConstantVector/IndirectBr.

I added 4 tests, and checked that make check-llvm works well.

Jun 30 2017, 5:58 AM

Jun 26 2017

chenwj created D34620: [DataLayout] Remove default argument from DataLayout APIs.
Jun 26 2017, 7:37 AM

Jun 18 2017

chenwj abandoned D33281: [Doc] Update how to install graphviz on macOS.
Jun 18 2017, 12:56 AM
chenwj updated the summary of D34325: [Doc] Fix getelementptr description about arguments.
Jun 18 2017, 12:19 AM
chenwj created D34325: [Doc] Fix getelementptr description about arguments.
Jun 18 2017, 12:17 AM

May 23 2017

chenwj added a comment to D33439: Fix comment in HexagonPacketizer::runOnMachineFunction.

@kparzysz please help me commit it as I have no commit access, thanks.

May 23 2017, 3:28 PM
chenwj created D33439: Fix comment in HexagonPacketizer::runOnMachineFunction.
May 23 2017, 6:04 AM
chenwj added inline comments to D33281: [Doc] Update how to install graphviz on macOS.
May 23 2017, 5:46 AM

May 22 2017

chenwj added inline comments to D33281: [Doc] Update how to install graphviz on macOS.
May 22 2017, 10:09 AM

May 21 2017

chenwj added a comment to D33281: [Doc] Update how to install graphviz on macOS.

It looks, at least to me, like graphviz.org has mac downloads and is official.
Is there a reason not to use that?

May 21 2017, 5:16 AM

May 20 2017

chenwj added a comment to D32929: [Doc] Fix LangRef links referred in GetElementPtr.rst.

This is obvious, please feel free to commit things like this in the future without review.

May 20 2017, 3:17 PM

May 17 2017

chenwj added a comment to D33281: [Doc] Update how to install graphviz on macOS.

@grosser I add you as reviewer because you once responded my mail [1].

May 17 2017, 8:15 AM
chenwj created D33281: [Doc] Update how to install graphviz on macOS.
May 17 2017, 8:13 AM

May 16 2017

chenwj closed D31578: Fix LLVM Programmer’s Manual doxygen links.

@dberris Thanks for the info!

May 16 2017, 6:02 AM

May 11 2017

chenwj added a comment to D32964: [Doc] Document "Splat" in the lexicon.

How about we add another hardware example and group those together:

May 11 2017, 6:14 AM
chenwj updated the diff for D32964: [Doc] Document "Splat" in the lexicon.

Add more example.

May 11 2017, 6:13 AM

May 10 2017

chenwj added a comment to D31578: Fix LLVM Programmer’s Manual doxygen links.

Looks reasonable to me.

May 10 2017, 6:03 AM
chenwj updated the diff for D32964: [Doc] Document "Splat" in the lexicon.

@spatel @aemerson Done. If everything looks fine, please help me commit it as I have no commit access, thanks.

May 10 2017, 6:01 AM
chenwj added a comment to D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint.

The difference between returning true and false here is just the way error recovery works: when we return true, we know the type is invalid, so we suppress it, and subsequent errors involving the declaration. Example (Objective-C++) where we currently print two errors:

So when we see T->isObjCObjectType() is true, then we should return true since the return type is invalid?

Yes.

May 10 2017, 5:50 AM

May 8 2017

chenwj added a comment to D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint.

The difference between returning true and false here is just the way error recovery works: when we return true, we know the type is invalid, so we suppress it, and subsequent errors involving the declaration. Example (Objective-C++) where we currently print two errors:

May 8 2017, 6:44 AM
chenwj created D32964: [Doc] Document "Splat" in the lexicon.
May 8 2017, 6:06 AM

May 5 2017

chenwj added a comment to D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint.

@erichkeane Just share what I investigated.

May 5 2017, 11:32 PM
chenwj updated subscribers of D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint.

@eli.friedman I find you added isObjCObjectType check in svn revision 184006 (git commit ddb5a392). Could you confirm returning zero rather than true here is okay? A little explanation would be even better. Thanks.

May 5 2017, 11:08 PM
chenwj created D32929: [Doc] Fix LangRef links referred in GetElementPtr.rst.
May 5 2017, 5:05 PM
chenwj abandoned D6034: Fix GettingStarted.rst statement.

The GettingStarted.rst already been updated.

May 5 2017, 5:32 AM
chenwj added a comment to D31578: Fix LLVM Programmer’s Manual doxygen links.

@t.p.northover Ping? :-)

May 5 2017, 5:30 AM

May 4 2017

chenwj added a comment to D32682: Refactoring with range-based for, NFC.

I have no right to commit, need someone's help. :-)

May 4 2017, 6:43 AM
chenwj updated the diff for D32682: Refactoring with range-based for, NFC.

@kparzysz There are two places I think using auto should be okay, replacing other auto with type.

May 4 2017, 6:40 AM
chenwj updated the diff for D32682: Refactoring with range-based for, NFC.
May 4 2017, 6:33 AM
chenwj updated the diff for D32682: Refactoring with range-based for, NFC.

@kparzysz All done. :-)

May 4 2017, 5:38 AM

May 3 2017

chenwj added a comment to D32682: Refactoring with range-based for, NFC.

@spatel I update the code. please take a look, thanks. :-)

May 3 2017, 7:48 AM
chenwj updated the diff for D32682: Refactoring with range-based for, NFC.

Use SDep & or const SDep & rather than auto.

May 3 2017, 7:47 AM
chenwj added a comment to D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint.

Ah, sorry. "Our Tests" means the lit test SemaObjC/method-bad-param.m (line 11). I ran the lit tests initially with a breakpoint on this line and it never hit, though I must have set up the debugger wrong. Once I replaced it with an assert, method-bad-param failed.

May 3 2017, 6:11 AM

May 2 2017

chenwj added a comment to D32117: Update TableGen LangIntro.rst.
In D32117#743341, @asb wrote:

Patch committed, many thanks for your contribution @chenwj.

May 2 2017, 7:07 AM
chenwj added a comment to D32682: Refactoring with range-based for, NFC.

IMO, this is going beyond LLVM's normal 'auto' usage prefs:
http://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable

If you can convert it to a range-loop, then you should specify the range element type including 'const' where appropriate. So something like this:

for (const SDValue &Op : NI->op_values())

Some of the diffs use regular loops and only replace the iterator type with an 'auto'. That should be a separate NFC patch. But it's not clear to me if that also goes too far into 'auto'.

May 2 2017, 5:21 AM

Apr 30 2017

chenwj added a comment to D32117: Update TableGen LangIntro.rst.

@asb Ping? :-)

Apr 30 2017, 7:30 AM
chenwj added reviewers for D32682: Refactoring with range-based for, NFC: MatzeB, kparzysz, spatel.
Apr 30 2017, 7:28 AM
chenwj created D32682: Refactoring with range-based for, NFC.
Apr 30 2017, 7:27 AM

Apr 28 2017

chenwj added a comment to D32280: TableGen: Add support of Intrinsics with multiple returns.

@wenbos Could you explain why moving GetNumNodeResults up ahead solves the problem? I see one problem is Operator will be changed if it's SubClassOf("Intrinsic"), that might make GetNumNodeResults return the wrong result. I don't know if your patch is the right fix, although it works.

Apr 28 2017, 6:21 AM
chenwj added a comment to D32117: Update TableGen LangIntro.rst.
In D32117#740495, @asb wrote:

Thank you @chenwj, this is definitely an improvement over the current documentation. Would you like me to commit?

Apr 28 2017, 5:09 AM

Apr 27 2017

chenwj added a comment to D32117: Update TableGen LangIntro.rst.

@asb And you? :-)

Apr 27 2017, 1:03 PM
chenwj added a comment to D32594: Fix typo and place comment close to its target.

I don't have commit access, need your help. ;-)

Apr 27 2017, 7:25 AM
chenwj created D32594: Fix typo and place comment close to its target.
Apr 27 2017, 6:56 AM
chenwj added a comment to D32117: Update TableGen LangIntro.rst.
In D32117#736622, @asb wrote:

Hi, thanks for the patch. My feedback is:

  1. Limitations of literal formats shouldn't be discussed when introducing the types.
  2. Perhaps outside the scope of this patch, but it does seem a little odd that a simple string literal can be assigned to either a string or code variable, but code fragment literals can't be assigned to string variables (at least on the couple of months old build on LLVM I have on this machine). The existing description that a code fragment is "just a multiline string literal" seems incorrect due to this.
Apr 27 2017, 6:36 AM
chenwj added a comment to D32117: Update TableGen LangIntro.rst.

Also, does the document mention expressions like "Inst{31,27-25,14}", where the bit accesses are in a comma-separated list?

Apr 27 2017, 6:32 AM
chenwj updated the diff for D32117: Update TableGen LangIntro.rst.

Address review comments.

Apr 27 2017, 6:24 AM

Apr 24 2017

chenwj added a comment to D32117: Update TableGen LangIntro.rst.

Ping? :-)

Apr 24 2017, 4:33 AM

Apr 19 2017

chenwj added a comment to D32117: Update TableGen LangIntro.rst.

Ping? Any comment? :-)

Apr 19 2017, 5:16 AM

Apr 16 2017

chenwj updated the diff for D32117: Update TableGen LangIntro.rst.

fix typo.

Apr 16 2017, 1:46 AM
chenwj updated the summary of D32117: Update TableGen LangIntro.rst.
Apr 16 2017, 1:43 AM
chenwj updated the summary of D32117: Update TableGen LangIntro.rst.
Apr 16 2017, 1:43 AM
chenwj updated the summary of D32117: Update TableGen LangIntro.rst.
Apr 16 2017, 1:42 AM
chenwj created D32117: Update TableGen LangIntro.rst.
Apr 16 2017, 1:40 AM

Apr 13 2017

chenwj added a comment to D32014: Remove unused varible.

Ping? :-)

Apr 13 2017, 11:54 PM
chenwj added a comment to D32014: Remove unused varible.

I don't have commit access, need someone's help. :-)

Apr 13 2017, 2:54 PM
chenwj created D32014: Remove unused varible.
Apr 13 2017, 7:43 AM

Apr 3 2017

chenwj added a comment to D31578: Fix LLVM Programmer’s Manual doxygen links.

I don't have commit access, need someone's help.

Apr 3 2017, 3:32 PM

Apr 2 2017

chenwj added reviewers for D31578: Fix LLVM Programmer’s Manual doxygen links: t.p.northover, rafael.
Apr 2 2017, 3:23 PM
chenwj created D31578: Fix LLVM Programmer’s Manual doxygen links.
Apr 2 2017, 5:35 AM

Mar 29 2017

chenwj added a comment to D6034: Fix GettingStarted.rst statement.

I don't have commit access, need someone's help.

Mar 29 2017, 6:45 AM
chenwj removed a reviewer for D6034: Fix GettingStarted.rst statement: chenwj.
Mar 29 2017, 6:09 AM
chenwj accepted D6034: Fix GettingStarted.rst statement.
Mar 29 2017, 5:41 AM

Oct 30 2014

chenwj retitled D6034: Fix GettingStarted.rst statement from to Fix GettingStarted.rst statement.
Oct 30 2014, 4:18 AM

Oct 27 2014

chenwj added a comment to D6011: Fix CPPBackend CodeGen.

I think this looks fine, having chased down the default arguments. But just to make sure: we both think the verifier will default to dbgs() for its output after this change (mainly rather than /dev/null)?

If so, go for it (and thanks for working on the update).

Tim.

Oct 27 2014, 8:55 PM
chenwj retitled D6011: Fix CPPBackend CodeGen from to Fix CPPBackend CodeGen.
Oct 27 2014, 8:27 PM