This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] MessagePack reader/writer
AbandonedPublic

Authored by scott.linder on Mar 22 2018, 2:24 PM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Summary

Add low-level MessagePack reader/writer in Utils.

Diff Detail

Event Timeline

scott.linder created this revision.Mar 22 2018, 2:24 PM

Since MsgPack is certainly not AMDGPU-specific, this should go into a target-independent utils directory, possibly lib/Support/.

Also, where does the code come from? Unless you really reimplemented everything yourself, there should be a note about that. Also, it would be good to explain in the summary / commit message why we want to add this.

Since MsgPack is certainly not AMDGPU-specific, this should go into a target-independent utils directory, possibly lib/Support/.

+1