This is the patch that lowers x86 intrinsics to native IR
in order to enable optimizations.
Corresponding llvm part: https://reviews.llvm.org/D44785
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
- Build Status
Buildable 16584 Build 16584: arc lint + arc unit
Event Timeline
lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
8304 | We can't - SignedMaxValue is created in non-extended type and llvm::ConstantInt::get makes an assertion that the input is of the same type. We can perform sext() on SignedMaxValue but the result will be the same. |
Comment Actions
LGTM with that one comment.
lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
8288 | You could probably just do ResultType->getScalarSizeInBits() == 8 |
You could probably just do ResultType->getScalarSizeInBits() == 8