Page MenuHomePhabricator
People aivchenk

aivchenk (Alexander Ivchenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2015, 3:57 AM (390 w, 6 d)

Recent Activity
View All

Oct 26 2018

aivchenk created D53765: [RFC prototype] Implementation of asm-goto support in LLVM.
Oct 26 2018, 7:59 AM · Restricted Project

Oct 9 2018

aivchenk added a comment to D50064: [MachineCopyPropagation] Improve redundant copy elimination.

kind ping?

Oct 9 2018, 7:03 AM

Oct 8 2018

aivchenk committed rL343966: [GlobalIsel][X86] Support G_UDIV/G_UREM/G_SREM.
[GlobalIsel][X86] Support G_UDIV/G_UREM/G_SREM
Oct 8 2018, 6:42 AM
aivchenk closed D49781: [GlobalIsel][X86] Support G_UDIV/G_UREM/G_SREM.
Oct 8 2018, 6:42 AM

Sep 3 2018

xiangzhai awarded D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value a Like token.
Sep 3 2018, 8:49 PM

Aug 31 2018

aivchenk committed rL341202: [GlobalISel][X86] Add the support for G_FPTRUNC.
[GlobalISel][X86] Add the support for G_FPTRUNC
Aug 31 2018, 4:28 AM
aivchenk closed D49855: [GlobalISel][x86] Add the support for G_FPTRUNC.
Aug 31 2018, 4:28 AM
aivchenk committed rL341200: [GlobalISel][X86_64] Support for G_FPTOSI.
[GlobalISel][X86_64] Support for G_FPTOSI
Aug 31 2018, 4:20 AM
aivchenk closed D49183: [GlobalISel][X86_64] Support for G_FPTOSI.
Aug 31 2018, 4:19 AM
aivchenk committed rL341199: [GlobalIsel][X86] Support for llvm.trap intrinsic.
[GlobalIsel][X86] Support for llvm.trap intrinsic
Aug 31 2018, 4:06 AM
aivchenk closed D49180: [GlobalIsel][X86] Support for llvm.trap intrinsic.
Aug 31 2018, 4:06 AM
aivchenk committed rL341198: [NFC] Fix unused variable warning in X86RegisterBankInfo.cpp.
[NFC] Fix unused variable warning in X86RegisterBankInfo.cpp
Aug 31 2018, 3:41 AM
aivchenk committed rL341193: [GlobalIsel][X86] Support for G_FCMP.
[GlobalIsel][X86] Support for G_FCMP
Aug 31 2018, 2:41 AM
aivchenk closed D49172: [GlobalIsel][X86] Support for G_FCMP.
Aug 31 2018, 2:41 AM

Aug 30 2018

aivchenk committed rL341072: Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions.
Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions
Aug 30 2018, 7:36 AM
aivchenk closed D49913: Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions.
Aug 30 2018, 7:35 AM

Aug 21 2018

aivchenk added a comment to D47467: [IR] Begin removal of TerminatorInst by removing successor manipulation..

Hi Chandler, are you still planning to work on that?

Aug 21 2018, 1:08 AM

Aug 17 2018

aivchenk accepted D50260: [X86] Fix liveness information when expanding X86::EH_SjLj_LongJmp64.

Thanks for the fix. LGTM

Aug 17 2018, 6:11 AM

Aug 2 2018

aivchenk committed rL338689: [GlobalISel] Fix typo with missed override specifier.
[GlobalISel] Fix typo with missed override specifier
Aug 2 2018, 1:55 AM
aivchenk committed rL338685: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per….
[GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per…
Aug 2 2018, 1:34 AM
aivchenk closed D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value.
Aug 2 2018, 1:34 AM

Aug 1 2018

aivchenk added a comment to D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value.

Hi Roman, I would prefer to do it as separate patches: the first one for Value splitting routine and the second for one splitToValueTypes

Aug 1 2018, 2:50 PM
aivchenk updated the diff for D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value.

Thanks for your comments. Indeed the struct handling is not very well covered with tests in x86. I added the tests for cases, which are supported now

Aug 1 2018, 6:13 AM

Jul 31 2018

aivchenk created D50064: [MachineCopyPropagation] Improve redundant copy elimination.
Jul 31 2018, 7:24 AM

Jul 27 2018

aivchenk added inline comments to D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value.
Jul 27 2018, 7:32 AM
aivchenk added a comment to D45204: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.

Thanks, I submitted this idea for a review here: https://reviews.llvm.org/D49913

Jul 27 2018, 6:50 AM
aivchenk created D49913: Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions.
Jul 27 2018, 6:06 AM

Jul 26 2018

aivchenk created D49855: [GlobalISel][x86] Add the support for G_FPTRUNC.
Jul 26 2018, 7:20 AM
aivchenk added a comment to D45204: [X86][MIPS][ARM] New machine instruction property 'isMoveReg'.

In a lot of cases, we would like to treat MoveReg-type instructions and generic COPY instruction in the same way.
E.g. in this code:

Jul 26 2018, 5:39 AM

Jul 25 2018

aivchenk created D49781: [GlobalIsel][X86] Support G_UDIV/G_UREM/G_SREM.
Jul 25 2018, 2:39 AM

Jul 23 2018

aivchenk created D49660: [GlobalISel] Rewrite CallLowering::lowerReturn to accept multiple VRegs per Value.
Jul 23 2018, 3:30 AM

Jul 11 2018

aivchenk created D49183: [GlobalISel][X86_64] Support for G_FPTOSI.
Jul 11 2018, 6:47 AM
aivchenk created D49180: [GlobalIsel][X86] Support for llvm.trap intrinsic.
Jul 11 2018, 6:07 AM
aivchenk closed D47132: [GlobalISel][X86_64] Support for G_SITOFP.

the fix is committed as rL336703. Sorry about the duplication

Jul 11 2018, 2:57 AM
aivchenk updated the diff for D49172: [GlobalIsel][X86] Support for G_FCMP.

added context

Jul 11 2018, 2:56 AM
aivchenk created D49172: [GlobalIsel][X86] Support for G_FCMP.
Jul 11 2018, 2:54 AM

Jul 10 2018

aivchenk committed rL336703: [GlobalISel][X86_64] Support for G_SITOFP.
[GlobalISel][X86_64] Support for G_SITOFP
Jul 10 2018, 9:43 AM

Jun 5 2018

aivchenk committed rL333990: [X86][CET] Shadow stack fix for setjmp/longjmp.
[X86][CET] Shadow stack fix for setjmp/longjmp
Jun 5 2018, 2:28 AM
aivchenk closed D47311: [X86][CET] Shadow stack fix for setjmp/longjmp.
Jun 5 2018, 2:28 AM

Jun 4 2018

aivchenk committed rL333951: [X86][ELF][CET] Adding the .note.gnu.property ELF section in X86.
[X86][ELF][CET] Adding the .note.gnu.property ELF section in X86
Jun 4 2018, 2:12 PM
aivchenk closed D47145: [X86][ELF][CET] Adding the .note.gnu.property ELF section in X86.
Jun 4 2018, 2:11 PM
aivchenk committed rL333908: [llvm-readobj] Support GNU_PROPERTY_X86_FEATURE_1_AND notes in .note.gnu..
[llvm-readobj] Support GNU_PROPERTY_X86_FEATURE_1_AND notes in .note.gnu.
Jun 4 2018, 8:18 AM

Jun 1 2018

aivchenk committed rL333750: [x86] NFC. Reautogenerate test/CodeGen/X86/vector-half-conversions.ll.
[x86] NFC. Reautogenerate test/CodeGen/X86/vector-half-conversions.ll
Jun 1 2018, 6:56 AM

May 29 2018

aivchenk committed rL333424: [llvm-readobj] Support GNU_PROPERTY_X86_FEATURE_1_AND notes in .note.gnu..
[llvm-readobj] Support GNU_PROPERTY_X86_FEATURE_1_AND notes in .note.gnu.
May 29 2018, 7:54 AM
aivchenk closed D47473: [llvm-readobj] Support GNU_PROPERTY_X86_FEATURE_1_AND notes in .note.gnu.property.
May 29 2018, 7:53 AM
aivchenk committed rL333419: [X86] Scalar mask and scalar move optimizations.
[X86] Scalar mask and scalar move optimizations
May 29 2018, 7:33 AM
aivchenk closed D47012: [X86] Scalar mask and scalar move optimizations.
May 29 2018, 7:33 AM

May 21 2018

aivchenk updated the diff for D47132: [GlobalISel][X86_64] Support for G_SITOFP.

added context

May 21 2018, 3:06 AM
aivchenk created D47132: [GlobalISel][X86_64] Support for G_SITOFP.
May 21 2018, 3:03 AM

May 18 2018

aivchenk committed rL332705: [X86][CET] Changing -fcf-protection behavior to comply with gcc (LLVM part).
[X86][CET] Changing -fcf-protection behavior to comply with gcc (LLVM part)
May 18 2018, 5:02 AM
aivchenk closed D46882: [X86][CET] Changing -fcf-protection behavior to comply with gcc (LLVM part).
May 18 2018, 5:02 AM
aivchenk committed rL332704: This patch aims to match the changes introduced.
This patch aims to match the changes introduced
May 18 2018, 5:00 AM
aivchenk committed rC332704: This patch aims to match the changes introduced.
This patch aims to match the changes introduced
May 18 2018, 5:00 AM
aivchenk closed D46881: [X86][CET] Changing -fcf-protection behavior to comply with gcc (clang part).
May 18 2018, 5:00 AM

May 8 2018

aivchenk committed rL331748: [X86][CET] Shadow stack fix for setjmp/longjmp.
[X86][CET] Shadow stack fix for setjmp/longjmp
May 8 2018, 2:08 AM
aivchenk closed D46181: [X86][CET] Shadow stack fix for setjmp/longjmp.
May 8 2018, 2:08 AM

Apr 24 2018

aivchenk closed D45572: [X86] Replace action Promote with Custom for operation ISD::SINT_TO_FP.
Apr 24 2018, 6:01 AM
aivchenk committed rL330711: [X86] Replace action Promote with Expand for operation ISD::SINT_TO_FP.
[X86] Replace action Promote with Expand for operation ISD::SINT_TO_FP
Apr 24 2018, 6:01 AM

Apr 19 2018

aivchenk added a comment to rL329934: [ORC] Plumb error notifications through the VSO interface..

glad to help :)

Apr 19 2018, 12:36 PM
aivchenk added inline comments to rL329934: [ORC] Plumb error notifications through the VSO interface..
Apr 19 2018, 5:54 AM
aivchenk committed rL330323: Lowering x86 adds/addus/subs/subus intrinsics (clang).
Lowering x86 adds/addus/subs/subus intrinsics (clang)
Apr 19 2018, 5:18 AM
aivchenk committed rC330323: Lowering x86 adds/addus/subs/subus intrinsics (clang).
Lowering x86 adds/addus/subs/subus intrinsics (clang)
Apr 19 2018, 5:18 AM
aivchenk closed D44786: Lowering x86 adds/addus/subs/subus intrinsics (clang).
Apr 19 2018, 5:18 AM
aivchenk committed rL330322: Lowering x86 adds/addus/subs/subus intrinsics (llvm part).
Lowering x86 adds/addus/subs/subus intrinsics (llvm part)
Apr 19 2018, 5:17 AM
aivchenk closed D44785: Lowering x86 adds/addus/subs/subus intrinsics (llvm part).
Apr 19 2018, 5:17 AM

Apr 16 2018

aivchenk added inline comments to rL329293: Re-land r329273: [Plugins] Add a slim plugin API to work together with the new….
Apr 16 2018, 12:07 PM

Mar 14 2018

aivchenk committed rL327520: [GlobalIsel][X86] Support for G_SDIV instruction.
[GlobalIsel][X86] Support for G_SDIV instruction
Mar 14 2018, 8:43 AM
aivchenk closed D44430: [GlobalIsel][X86] Support for G_SDIV instruction.
Mar 14 2018, 8:43 AM
aivchenk committed rL327499: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.
[GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL
Mar 14 2018, 4:26 AM
aivchenk closed D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.
Mar 14 2018, 4:26 AM
aivchenk committed rL327482: [GlobalIsel][X86] Support for G_ZEXT instruction.
[GlobalIsel][X86] Support for G_ZEXT instruction
Mar 14 2018, 2:16 AM
aivchenk closed D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.
Mar 14 2018, 2:15 AM

Mar 13 2018

aivchenk created D44430: [GlobalIsel][X86] Support for G_SDIV instruction.
Mar 13 2018, 8:04 AM
aivchenk updated the diff for D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.

Added context

Mar 13 2018, 2:14 AM
aivchenk updated the diff for D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.

added context

Mar 13 2018, 2:14 AM
aivchenk added a comment to D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.

Right, sorry about that. One sec

Mar 13 2018, 2:12 AM
aivchenk updated the diff for D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.

Fix for a typo:

Mar 13 2018, 1:47 AM

Mar 12 2018

aivchenk created D44395: [GlobalISel][X86] Support G_LSHR/G_ASHR/G_SHL.
Mar 12 2018, 10:11 AM
aivchenk created D44378: [GlobalIsel][X86] Support for G_ZEXT instruction.
Mar 12 2018, 5:27 AM

Mar 5 2018

aivchenk committed rL326689: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics.
[x86][CET] Introduce _get_ssp, _inc_ssp intrinsics
Mar 5 2018, 3:34 AM
aivchenk committed rC326689: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics.
[x86][CET] Introduce _get_ssp, _inc_ssp intrinsics
Mar 5 2018, 3:34 AM
aivchenk closed D43814: [x86][CET] Introduce _get_ssp, _inc_ssp intrinsics.
Mar 5 2018, 3:34 AM

Feb 28 2018

aivchenk committed rL326320: [GlobalIsel][X86] Support G_INTTOPTR instruction..
[GlobalIsel][X86] Support G_INTTOPTR instruction.
Feb 28 2018, 4:16 AM
aivchenk closed D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..
Feb 28 2018, 4:16 AM
aivchenk committed rL326311: [GlobalIsel][X86] Support G_PTRTOINT instruction..
[GlobalIsel][X86] Support G_PTRTOINT instruction.
Feb 28 2018, 1:21 AM
aivchenk closed D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..
Feb 28 2018, 1:21 AM

Feb 27 2018

aivchenk updated the diff for D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..

addressed comments. Added legalizer and general tests

Feb 27 2018, 3:57 AM

Feb 22 2018

aivchenk updated the diff for D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..

added legalizer tests

Feb 22 2018, 1:37 PM
aivchenk updated the diff for D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..

Added tests for legalizer

Feb 22 2018, 1:06 PM
aivchenk created D43622: [GlobalIsel][X86] Support G_INTTOPTR instruction..
Feb 22 2018, 7:57 AM
aivchenk created D43617: [GlobalIsel][X86] Support G_PTRTOINT instruction..
Feb 22 2018, 6:26 AM

Feb 15 2018

aivchenk closed D43087: [SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV.

Right, sorry about that. So the fix is committed as rL325135

Feb 15 2018, 4:57 AM

Feb 14 2018

aivchenk committed rL325135: [SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV.
[SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV
Feb 14 2018, 7:58 AM
aivchenk updated the diff for D43087: [SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV.

Provided context

Feb 14 2018, 6:42 AM
aivchenk updated the diff for D43087: [SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV.

That makes sense, thanks for the comments. In the new version there is a change in compress_expand.ll, which in my view is ok

Feb 14 2018, 5:28 AM
aivchenk added a comment to D43087: [SelectionDAG][X86] Fix incorrect offset generated for VMASKMOV.

The problem originated from a miscompare in a benchmark. That appeared to be a machine-scheduler that moved writes after reads of a pointer. It turned out that the scheduler was within its rights to do so, as it checked the offset of the following pointer:

Feb 14 2018, 4:29 AM

Feb 13 2018

aivchenk committed rL324997: [X86] Rename function main->foo in CodeGen/X86/pr35316.ll. NFC.
[X86] Rename function main->foo in CodeGen/X86/pr35316.ll. NFC
Feb 13 2018, 3:00 AM

Feb 8 2018

aivchenk added a comment to D37775: Add a verifier test to check the access on both sides of COPY are the same.

X86 part is submitted. All ready to go :)

Feb 8 2018, 2:51 PM
aivchenk committed rL324665: [GlobalISel][X86] Fixing failures after https://reviews.llvm.org/D37775.
[GlobalISel][X86] Fixing failures after https://reviews.llvm.org/D37775
Feb 8 2018, 2:44 PM
aivchenk committed rL324664: [GlobalIsel][X86] Making {G_IMPLICIT_DEF, s128} legal.
[GlobalIsel][X86] Making {G_IMPLICIT_DEF, s128} legal
Feb 8 2018, 2:43 PM