This is an archive of the discontinued LLVM Phabricator instance.

TableGen: Remove redundant loop in ListInit::resolveReferences
ClosedPublic

Authored by nhaehnle on Mar 19 2018, 7:29 AM.

Reviewers

Commits

Summary

Recursive lookups are handled by the Resolver, so the loop was purely
a waste of runtime.

Change-Id: I2bd23a68b478aea0bbac1a86ca7635adffa28688

tra accepted this revision.Mar 19 2018, 1:29 PM

This revision is now accepted and ready to land.Mar 19 2018, 1:29 PM

Wow. There were 50 patches in the stack. Thank you, again, for making tablegen better.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

TableGen/

9 lines

	Show First 20 Lines • Show All 628 Lines • ▼ Show 20 Lines
	}			}

	Init *ListInit::resolveReferences(Resolver &R) const {			Init *ListInit::resolveReferences(Resolver &R) const {
	SmallVector<Init*, 8> Resolved;			SmallVector<Init*, 8> Resolved;
	Resolved.reserve(size());			Resolved.reserve(size());
	bool Changed = false;			bool Changed = false;

	for (Init *CurElt : getValues()) {			for (Init *CurElt : getValues()) {
	Init *E;			Init *E = CurElt->resolveReferences(R);

	do {
	E = CurElt;
	CurElt = CurElt->resolveReferences(R);
	Changed \|= E != CurElt;			Changed \|= E != CurElt;
	} while (E != CurElt);
	Resolved.push_back(E);			Resolved.push_back(E);
	}			}

	if (Changed)			if (Changed)
	return ListInit::get(Resolved, getElementType());			return ListInit::get(Resolved, getElementType());
	return const_cast<ListInit *>(this);			return const_cast<ListInit *>(this);
	}			}

	▲ Show 20 Lines • Show All 1,613 Lines • Show Last 20 Lines