This is an archive of the discontinued LLVM Phabricator instance.

TableGen: Explicitly forbid some nestings of class, multiclass, and foreach
ClosedPublic

Authored by nhaehnle on Mar 5 2018, 12:21 PM.

Reviewers

Commits

Summary

These previously all failed one way or another, but now we produce a more
helpful error message.

Change-Id: I8ffd2e87c8e35a5134c3be289e0a1fecaa2bb8ca

tra accepted this revision.Mar 9 2018, 9:53 AM

This revision is now accepted and ready to land.Mar 9 2018, 9:53 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

TableGen/

12 lines

Show First 20 Lines • Show All 3,137 Lines • ▼ Show 20 Lines	bool TGParser::ParseObject(MultiClass *MC) {
case tgtok::Let: return ParseTopLevelLet(MC);		case tgtok::Let: return ParseTopLevelLet(MC);
case tgtok::Def: return ParseDef(MC);		case tgtok::Def: return ParseDef(MC);
case tgtok::Foreach: return ParseForeach(MC);		case tgtok::Foreach: return ParseForeach(MC);
case tgtok::Defm: return ParseDefm(MC);		case tgtok::Defm: return ParseDefm(MC);
case tgtok::Defset:		case tgtok::Defset:
if (MC)		if (MC)
return TokError("defset is not allowed inside multiclass");		return TokError("defset is not allowed inside multiclass");
return ParseDefset();		return ParseDefset();
case tgtok::Class: return ParseClass();		case tgtok::Class:
case tgtok::MultiClass: return ParseMultiClass();		if (MC)
		return TokError("class is not allowed inside multiclass");
		if (!Loops.empty())
		return TokError("class is not allowed inside foreach loop");
		return ParseClass();
		case tgtok::MultiClass:
		if (!Loops.empty())
		return TokError("multiclass is not allowed inside foreach loop");
		return ParseMultiClass();
}		}
}		}

/// ParseObjectList		/// ParseObjectList
/// ObjectList :== Object*		/// ObjectList :== Object*
bool TGParser::ParseObjectList(MultiClass *MC) {		bool TGParser::ParseObjectList(MultiClass *MC) {
while (isObjectStart(Lex.getCode())) {		while (isObjectStart(Lex.getCode())) {
if (ParseObject(MC))		if (ParseObject(MC))
Show All 15 Lines