This is an archive of the discontinued LLVM Phabricator instance.

Differential D43678

TableGen: Remove VarInit::getFieldType
ClosedPublic

Authored by nhaehnle on Feb 23 2018, 7:48 AM.

Details

Reviewers
arsenm
craig.topper
tra
MartinO
Commits
rG0d4ad84aa2f0: TableGen: Remove VarInit::getFieldType
rL326061: TableGen: Remove VarInit::getFieldType
Summary

It is redundant with the implementation in TypedInit.

Change-Id: I8ab1fb5c77e4923f7eb3ffae5889f0f8af6093b4

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle created this revision.Feb 23 2018, 7:48 AM
Herald added a subscriber: wdng. · View Herald TranscriptFeb 23 2018, 7:48 AM
Harbormaster completed remote builds in B15354: Diff 135641.Feb 23 2018, 7:48 AM
nhaehnle added a parent revision: D43563: TableGen: Get rid of Init::getFieldInit.Feb 23 2018, 7:48 AM
nhaehnle added a child revision: D43679: TableGen: Use DefInit::getDef() instead of the type's getRecord().Feb 23 2018, 7:52 AM
tra accepted this revision.Feb 23 2018, 11:01 AM
This revision is now accepted and ready to land.Feb 23 2018, 11:01 AM
Closed by commit rL326061: TableGen: Remove VarInit::getFieldType (authored by nha). · Explain WhyFeb 25 2018, 12:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
include/
llvm/
TableGen/
2 lines
lib/
TableGen/
7 lines

Diff 135846

llvm/trunk/include/llvm/TableGen/Record.h

Show First 20 Lines • Show All 886 Lines • ▼ Show 20 Linespublic:
StringRef getName() const; StringRef getName() const;
Init *getNameInit() const { return VarName; } Init *getNameInit() const { return VarName; }
std::string getNameInitAsString() const { std::string getNameInitAsString() const {
return getNameInit()->getAsUnquotedString(); return getNameInit()->getAsUnquotedString();
} }
RecTy *getFieldType(StringInit *FieldName) const override;
/// This method is used by classes that refer to other /// This method is used by classes that refer to other
/// variables which may not be defined at the time they expression is formed. /// variables which may not be defined at the time they expression is formed.
/// If a value is set for the variable later, this method will be called on /// If a value is set for the variable later, this method will be called on
/// users of the value to allow the value to propagate out. /// users of the value to allow the value to propagate out.
/// ///
Init *resolveReferences(Record &R, const RecordVal *RV) const override; Init *resolveReferences(Record &R, const RecordVal *RV) const override;
Init *getBit(unsigned Bit) const override; Init *getBit(unsigned Bit) const override;
▲ Show 20 Lines • Show All 708 Lines • Show Last 20 Lines

llvm/trunk/lib/TableGen/Record.cpp

Show First 20 Lines • Show All 1,242 Lines • ▼ Show 20 Lines
} }
Init *VarInit::getBit(unsigned Bit) const { Init *VarInit::getBit(unsigned Bit) const {
if (getType() == BitRecTy::get()) if (getType() == BitRecTy::get())
return const_cast<VarInit*>(this); return const_cast<VarInit*>(this);
return VarBitInit::get(const_cast<VarInit*>(this), Bit); return VarBitInit::get(const_cast<VarInit*>(this), Bit);
} }
RecTy *VarInit::getFieldType(StringInit *FieldName) const {
if (RecordRecTy *RTy = dyn_cast<RecordRecTy>(getType()))
if (const RecordVal *RV = RTy->getRecord()->getValue(FieldName))
return RV->getType();
return nullptr;
}
Init *VarInit::resolveReferences(Record &R, const RecordVal *RV) const { Init *VarInit::resolveReferences(Record &R, const RecordVal *RV) const {
if (RecordVal *Val = R.getValue(VarName)) if (RecordVal *Val = R.getValue(VarName))
if (RV == Val || (!RV && !isa<UnsetInit>(Val->getValue()))) if (RV == Val || (!RV && !isa<UnsetInit>(Val->getValue())))
return Val->getValue(); return Val->getValue();
return const_cast<VarInit *>(this); return const_cast<VarInit *>(this);
} }
VarBitInit *VarBitInit::get(TypedInit *T, unsigned B) { VarBitInit *VarBitInit::get(TypedInit *T, unsigned B) {
▲ Show 20 Lines • Show All 557 Lines • Show Last 20 Lines