This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Default to DWARF 5 for Fuchsia
AbandonedPublic

Authored by phosek on Mar 17 2018, 6:26 PM.

Details

Reviewers
mcgrathr
Summary

We use DWARF 5 on Fuchsia, make it the toolchain default.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Mar 17 2018, 6:26 PM

We aren't actually using DWARF 5 yet AFAICT. Our builds don't pass -gdwarf-5. So I'm not sure we have yet verified that all the DWARF-consuming tools people are using with Fuchsia binaries can handle all of DWARF 5 (which has several major format changes). I'd certainly like 5 to be the default, but I think we need to establish a set of consumers we care about and verify their format version support before we can be sure about this.

I should also point out that even in DWARF v5 mode LLVM does not yet emit DWARF 5 variants of all sections as DWARF v5 support in LLVM is not yet feature-complete.

@mcgrathr This might be ready to land now.

mcgrathr accepted this revision.Nov 30 2021, 10:45 AM

lgtm, but we should be sure to advise users who may need to use -gdwarf-4 explicitly if their debugging tools become unhappy.

This revision is now accepted and ready to land.Nov 30 2021, 10:45 AM
phosek abandoned this revision.Apr 26 2022, 11:47 PM

No longer needed, this is now the Clang default.

Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2022, 11:47 PM
Herald added a subscriber: MaskRay. · View Herald Transcript