Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
docs/LangRef.rst | ||
---|---|---|
2300 ↗ | (On Diff #137789) | Using undef here is confusing, since it's not any specific value. If you want an SNaN, write an SNaN. |
Comment Actions
Patch updated:
- Fix example to show SNaN explicitly.
- Remove duplicate text from the opcode definitions. Now that we have a description of the environment, we can just point to it. Presumably, we'll do the same for non-constrained FP intrinsics, but I'll double-check those and make another patch.
Comment Actions
LGTM too.
I thought about mentioning IEEE-754 here, but I don't know how far we can or want to go in that direction.
I wouldn't mind doing this. We do, in fact, assume IEEE-754 representation (except for in special types) and we probably should document that.
Comment Actions
Great - thanks for clarifying that. We'd be in big trouble with existing folds if that wasn't true. :)
I'll commit this as-is and enhance in follow-ups.