Page MenuHomePhabricator

[clangd] Early return for #include goto definition.
ClosedPublic

Authored by hokein on Mar 8 2018, 5:33 AM.

Diff Detail

Event Timeline

hokein created this revision.Mar 8 2018, 5:33 AM
ilya-biryukov accepted this revision.Mar 8 2018, 7:33 AM

LGTM.
I think this was part of initial changed and I asked to make it this way, but I don't remember why.

This revision is now accepted and ready to land.Mar 8 2018, 7:33 AM

Sorry, being pedantic here... We're not saving time on parsing, but on walking over the AST :-)

LGTM.
I think this was part of initial changed and I asked to make it this way, but I don't remember why.

I think it was just to have a single place that returns. I think it's OK to early return in this case, it's a good optimization.

hokein edited the summary of this revision. (Show Details)Mar 8 2018, 8:08 AM

Sorry, being pedantic here... We're not saving time on parsing, but on walking over the AST :-)

Yeah, rephased it.

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.