Page MenuHomePhabricator

Propagate flags to SDValue in SplitVecOp_VECREDUCE
ClosedPublic

Authored by sabuasal on Mar 7 2018, 7:56 PM.

Details

Summary

This patch is a proposed fix for 36642.

While legalizing long vector types, make sure the smaller types get the
flags of the wider type.

Diff Detail

Event Timeline

sabuasal created this revision.Mar 7 2018, 7:56 PM
spatel added a subscriber: spatel.

Does D37686 handle this problem too?

Please add a test.

@spatel

Thanks for the review. I tried to apply the patch on tip, it applies cleanly but it doesn't compile, I think it is out of date.

sabuasal updated this revision to Diff 137641.Mar 8 2018, 12:33 PM

@aemerson

Test case added.

Thanks for the review!

sabuasal updated this revision to Diff 137645.Mar 8 2018, 1:02 PM

updated test name.

aemerson accepted this revision.Mar 8 2018, 2:32 PM

LGTM, can you also make the test name a little more specific, e.g. 'vecreduce-propagate-sd-flags.ll'?

test/CodeGen/AArch64/propagate-sdvalue-flags.ll
1

You will also need a REQUIRES: asserts since you use the -debug-only option.

This revision is now accepted and ready to land.Mar 8 2018, 2:32 PM
sabuasal closed this revision.Mar 8 2018, 3:46 PM

committed in @327079

sabuasal marked an inline comment as done.Mar 8 2018, 3:46 PM