This is an archive of the discontinued LLVM Phabricator instance.

[mips] Fix the definitions of the EVA instructions
ClosedPublic

Authored by sdardis on Mar 7 2018, 7:58 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Mar 7 2018, 7:58 AM
sdardis planned changes to this revision.Mar 9 2018, 3:32 AM

Based on my comments on D44176, I'm preparing another patch which is the splitting out of the ASEPredicate from InsnPredicates in PredicateControl.

sdardis updated this revision to Diff 137735.Mar 9 2018, 5:56 AM
sdardis edited the summary of this revision. (Show Details)

Update to account for splitting out one of the changes into D44299.

This revision is now accepted and ready to land.Mar 12 2018, 1:18 PM
sdardis added inline comments.Mar 13 2018, 4:27 AM
lib/Target/Mips/MicroMipsInstrInfo.td
963–990 ↗(On Diff #137735)

This change crept in from the next patch in the series, I'll remove it from this one.

lib/Target/Mips/MipsInstrInfo.td
2069 ↗(On Diff #137735)

As did this.

test/MC/Mips/micromips/valid.s
166–188 ↗(On Diff #137735)

And this.

sdardis updated this revision to Diff 138154.Mar 13 2018, 4:44 AM

Update to remove unrelated changes to trap instructions.

Anyway LGTM :)

This revision was automatically updated to reflect the committed changes.