This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Legality and RegBankInfo for G_{INSERT|EXTRACT}_VECTOR_ELT
ClosedPublic

Authored by arsenm on Mar 6 2018, 5:55 AM.

Details

Diff Detail

Event Timeline

arsenm created this revision.Mar 6 2018, 5:55 AM
nhaehnle added inline comments.Mar 7 2018, 1:45 AM
lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
459–460

What happens if the index operand is in an SGPR?

479–480

Same here, what if IdxOp is in an SGPR?

arsenm added inline comments.Mar 7 2018, 11:24 AM
lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
459–460

As implemented today, indirect addressing is only done on VGPRs. Someday we could implement SGPR indexing, but right now the register type of the index doesn't really matter

nhaehnle accepted this revision.Mar 9 2018, 2:34 AM

Okay, makes sense.

This revision is now accepted and ready to land.Mar 9 2018, 2:34 AM
arsenm closed this revision.Mar 12 2018, 6:39 AM

r327269