XFAIL: libcpp-no-deduction-guides in libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

[sqlbyme]

Summary

Refactor the previous version method of marking each apple-clang version as UNSUPPORTED and just XFAIL'ing the libcpp-no-deduction-guides instead. This brings this test inline with the same style as iter_alloc_deduction.pass.cpp

[vsk]

Is the test expected to pass with clang-902? If not, then it'd be best to use "apple-clang-9" instead of "apple-clang-9.0".

[vsapsai]

In D44103#1027664, @vsk wrote:

Is the test expected to pass with clang-902? If not, then it'd be best to use "apple-clang-9" instead of "apple-clang-9.0".

That means that most likely it should be apple-clang-8 instead of 8.0. But on the second thought it might be better to keep .fail.cpp and .pass.cpp more in sync. I think

// XFAIL: libcpp-no-deduction-guides

is better than listing all unsupported clang versions (see r325205). I didn't test it but if it works, I prefer this approach.

[EricWF]

I think the correct fix is something like this: https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e

[sqlbyme]

I copied what Eric did here: https://github.com/llvm-mirror/libcxx/commit/6878e852d1d26cca0abee3013822311cd894ca3e. I have tested this on our bots and the fix works fine.

[sqlbyme]

Eric,
Any chance you could have one more look at this and let me know if the
patch is acceptable?

Thanks,
Mike

libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp

 //===----------------------------------------------------------------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is dual licensed under the MIT and the University of Illinois Open
 // Source Licenses. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 // <string>
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// UNSUPPORTED: clang-3.3, clang-3.4, clang-3.5, clang-3.6, clang-3.7, clang-3.8, clang-3.9, clang-4.0
-// UNSUPPORTED: apple-clang-6, apple-clang-7, apple-clang-8.0
+// XFAIL: libcpp-no-deduction-guides
 
 // template<class InputIterator,
 //      class Allocator = allocator<typename iterator_traits<InputIterator>::value_type>>
 //  basic_string(InputIterator, InputIterator, Allocator = Allocator())
 //    -> basic_string<typename iterator_traits<InputIterator>::value_type,
 //                 char_traits<typename iterator_traits<InputIterator>::value_type>,
 //                 Allocator>;
 //