This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Switch the default exploration strategy to priority queue based on coverage
ClosedPublic

Authored by george.karpenkov on Feb 26 2018, 1:17 PM.

Diff Detail

Event Timeline

NoQ added a reviewer: szepet.Feb 26 2018, 1:23 PM

Peter, would you have time to see if the loop-unrolling changes are making sense - now or after the fact? Like, we're changing exploration order, so it'd bail-out on block counts and replay-without-inlining functions in a different manner, so numTimesReached counts get skewed. Do the two updated tests still demonstrate the expected behavior, or should a FIXME be added?

NoQ added a comment.Feb 26 2018, 4:59 PM

Or you can hardcode the old exploration order in the test run-lines.

Or hardcode both exploration orders - but in this case it's still be good to figure out if the other behavior is correct.

NoQ accepted this revision.Feb 26 2018, 5:00 PM

LGTM otherwise. I repeat that in my opinion this whole exploration order thing was a fantastic discovery.

This revision is now accepted and ready to land.Feb 26 2018, 5:00 PM
george.karpenkov added a subscriber: phosek.

I guess until we get a comment from @phosek let's test both.

This revision was automatically updated to reflect the committed changes.