This is an archive of the discontinued LLVM Phabricator instance.

[ADT] Recognize ppc as valid architecture in target triple.
ClosedPublic

Authored by JDevlieghere on Feb 26 2018, 3:17 AM.

Details

Summary

Until this patch, only powerpc and ppc32 were recognized as valid
PowerPC 32-bit architectures in a target triple. This was incompatible
with the triple ppc-apple-darwin as returned for libObject. I found
out about this when working on a test case using a binary generated on
an old PowerBook G4.

We had the choice of either fix this in the Mach-O object parser or
in the Triple implementation. I chose the latter because it feels like
the most canonical place.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Feb 26 2018, 3:17 AM
davide accepted this revision.Feb 26 2018, 7:59 AM
davide added a subscriber: davide.

LGTM.

This revision is now accepted and ready to land.Feb 26 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.