This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Use make<> rather then make_unique<>. NFC.
ClosedPublic

Authored by sbc100 on Feb 21 2018, 10:23 AM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Feb 21 2018, 10:23 AM
sbc100 retitled this revision from [WebAssebmly] Use make<> rather then make_unique<> to [WebAssembly] Use make<> rather then make_unique<>.

Is my rational correct here? Based on your feedback from my other change it seems like this should be preferred?

ruiu accepted this revision.Feb 21 2018, 10:26 AM

LGTM

This revision is now accepted and ready to land.Feb 21 2018, 10:26 AM
sbc100 retitled this revision from [WebAssembly] Use make<> rather then make_unique<> to [WebAssembly] Use make<> rather then make_unique<>. NFC..Feb 21 2018, 10:30 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.