[DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata

[chill]

Summary

Workaround for not yet explained buildbot issue.

http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/8694/console

[chill]

I'll add a test tomorrow.

[rogfer01]

lib/CodeGen/AsmPrinter/DwarfUnit.cpp

1433

I think if (DTy) suits more the existing coding standard elsewhere in this file.

[vsapsai]

Roger has a good point, I agree that if (DTy) is more consistent with the rest of the code, please change it when commit. Code looks good to me from the standpoint of fixing the build.

[chill]

Minor style change and added a test.

[vsapsai]

Thanks for the fix.

lib/CodeGen/AsmPrinter/DwarfUnit.cpp

if (auto *Element = dyn_cast_or_null<DINode>(Elements[i]))
       if (Element->getTag() == dwarf::DW_TAG_subrange_type)
         constructSubrangeDIE(Buffer, cast<DISubrange>(Element), IdxTy);
   }
 }
 
 void DwarfUnit::constructEnumTypeDIE(DIE &Buffer, const DICompositeType *CTy) {
   const DIType *DTy = resolve(CTy->getBaseType());
   bool IsUnsigned = DTy && isUnsignedDIType(DD, DTy);
-  if (DTy && DD->getDwarfVersion() >= 3)
+  if (DTy != nullptr) {
+    if (DD->getDwarfVersion() >= 3)
       addType(Buffer, DTy);
-  if (DD->getDwarfVersion() >= 4 && (CTy->getFlags() & DINode::FlagFixedEnum)) {
-    assert(DTy);
+    if (DD->getDwarfVersion() >= 4 && (CTy->getFlags() & DINode::FlagFixedEnum))
       addFlag(Buffer, dwarf::DW_AT_enum_class);
   }
 
   DINodeArray Elements = CTy->getElements();
 
   // Add enumerators to enumeration type.
   for (unsigned i = 0, N = Elements.size(); i < N; ++i) {
     auto *Enum = dyn_cast_or_null<DIEnumerator>(Elements[i]);
     if (Enum) {