This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Cleanup methods for add synthetic symbols to symtab
ClosedPublic

Authored by sbc100 on Feb 13 2018, 12:13 PM.

Details

Summary

These were duplicating (incorrectly) some of the logic for
handling conflicts, but since they are only ever added right
at the start we can assume no existing symbols.

Also rename these methods for clarity.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Feb 13 2018, 12:13 PM
sbc100 retitled this revision from [WebAssembly] Cleanup methods for add synthetic symbols to symbtab to [WebAssembly] Cleanup methods for add synthetic symbols to symtab.Feb 13 2018, 12:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 12:17 PM
This revision was automatically updated to reflect the committed changes.