Page MenuHomePhabricator
Differential D43252

[WebAssembly] Cleanup methods for add synthetic symbols to symtab
ClosedPublic
Actions

Authored by sbc100 on Feb 13 2018, 12:13 PM.

Details

Reviewers
ruiu
Commits
rGa189230bf511: [WebAssembly] Cleanup methods for add synthetic symbols to symbtab. NFC.
rLLD325045: [WebAssembly] Cleanup methods for add synthetic symbols to symbtab. NFC.
rL325045: [WebAssembly] Cleanup methods for add synthetic symbols to symbtab. NFC.
Summary

These were duplicating (incorrectly) some of the logic for
handling conflicts, but since they are only ever added right
at the start we can assume no existing symbols.

Also rename these methods for clarity.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Feb 13 2018, 12:13 PM
sbc100 retitled this revision from [WebAssembly] Cleanup methods for add synthetic symbols to symbtab to [WebAssembly] Cleanup methods for add synthetic symbols to symtab.Feb 13 2018, 12:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 12:17 PM
Closed by commit rL325045: [WebAssembly] Cleanup methods for add synthetic symbols to symbtab. NFC. (authored by sbc, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 134096

View Options

lld/trunk/wasm/Driver.cpp

Loading...
View Options

lld/trunk/wasm/SymbolTable.h

Loading...
View Options

lld/trunk/wasm/SymbolTable.cpp

Loading...