This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Change constant addr space to 4 for clang
ClosedPublic

Authored by yaxunl on Feb 11 2018, 1:11 PM.

Diff Detail

Repository
rC Clang

Event Timeline

yaxunl created this revision.Feb 11 2018, 1:11 PM
t-tye accepted this revision.Feb 12 2018, 9:14 AM

LGTM. Other clean up can be done as a separate patch.

test/CodeGenOpenCL/address-spaces.cl
37

Suggest using the same name across all the OpenCL tests as some are using GIZ, some AMD and some AMDGCN. AMDGCN seems the clearer now that only have a single address space mapping? Similar comment for other places GIZ/AMD is being mentioned.

test/CodeGenOpenCL/amdgpu-env-amdgiz.cl
4

Should this test be renamed to amdgpu-env-amdgcn.cl now there is a single address space mapping (and delete any relating to the old mapping if they exist)?

This revision is now accepted and ready to land.Feb 12 2018, 9:14 AM
yaxunl added inline comments.Feb 13 2018, 8:31 AM
test/CodeGenOpenCL/address-spaces.cl
37

Will have a separate patch to cleanup the tests.

test/CodeGenOpenCL/amdgpu-env-amdgiz.cl
4

will rename it when committing.

This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.