This is an archive of the discontinued LLVM Phabricator instance.

[Analyzer] Fix a typo about `categories::MemoryError` in `MallocChecker.cpp`
ClosedPublic

Authored by MTC on Feb 8 2018, 7:43 AM.

Download Raw Diff

Details

Reviewers

NoQ
xazax.hun
george.karpenkov
a.sidorin

Commits

rG9849f595b9f9: [analyzer] MallocChecker: Fix one more bug category.
rC324680: [analyzer] MallocChecker: Fix one more bug category.
rL324680: [analyzer] MallocChecker: Fix one more bug category.

Summary

It should be an omission when committing rL302016.

Diff Detail

Repository: rL LLVM

Event Timeline

MTC created this revision.Feb 8 2018, 7:43 AM

Herald added a reviewer: george.karpenkov. · View Herald TranscriptFeb 8 2018, 7:43 AM

Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. · View Herald Transcript

Harbormaster completed remote builds in B14757: Diff 133423.Feb 8 2018, 7:44 AM

LGTM.

This revision is now accepted and ready to land.Feb 8 2018, 7:53 AM

Woohoo thanks nice.

I guess this happened due to a race with rL301913. My bad anyways^^

Closed by commit rC324680: [analyzer] MallocChecker: Fix one more bug category. (authored by NoQ). · Explain WhyFeb 8 2018, 3:32 PM

Closed by commit rL324680: [analyzer] MallocChecker: Fix one more bug category. (authored by NoQ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 8 2018, 3:32 PM

Revision Contents

Path

Size

cfe/

trunk/

lib/

StaticAnalyzer/

Checkers/

MallocChecker.cpp

4 lines

test/

Analysis/

malloc-fnptr-plist.c

11 lines

Diff 133522

cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Show First 20 Lines • Show All 2,069 Lines • ▼ Show 20 Lines	if (!ChecksEnabled[CK_MallocChecker])
return;		return;

Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, FreeExpr);		Optional<MallocChecker::CheckKind> CheckKind = getCheckIfTracked(C, FreeExpr);
if (!CheckKind.hasValue())		if (!CheckKind.hasValue())
return;		return;

if (ExplodedNode *N = C.generateErrorNode()) {		if (ExplodedNode *N = C.generateErrorNode()) {
if (!BT_BadFree[*CheckKind])		if (!BT_BadFree[*CheckKind])
BT_BadFree[*CheckKind].reset(		BT_BadFree[*CheckKind].reset(new BugType(
new BugType(CheckNames[*CheckKind], "Bad free", "Memory Error"));		CheckNames[*CheckKind], "Bad free", categories::MemoryError));

SmallString<100> Buf;		SmallString<100> Buf;
llvm::raw_svector_ostream Os(Buf);		llvm::raw_svector_ostream Os(Buf);

const MemRegion *MR = ArgVal.getAsRegion();		const MemRegion *MR = ArgVal.getAsRegion();
while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))		while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
MR = ER->getSuperRegion();		MR = ER->getSuperRegion();

▲ Show 20 Lines • Show All 863 Lines • Show Last 20 Lines

cfe/trunk/test/Analysis/malloc-fnptr-plist.c

				// RUN: %clang_analyze_cc1 -analyzer-checker core,unix.Malloc -analyzer-output=plist -o %t.plist -verify %s
				// RUN: FileCheck --input-file=%t.plist %s

				void free(void *);
				void (*fnptr)(int);
				void foo() {
				free((void *)fnptr); // expected-warning{{Argument to free() is a function pointer}}
				}

				// Make sure the bug category is correct.
				// CHECK: <key>category</key><string>Memory error</string>