This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Support simpler JSON-RPC stream parsing for lit tests.
ClosedPublic

Authored by sammccall on Feb 5 2018, 11:16 AM.

Event Timeline

sammccall created this revision.Feb 5 2018, 11:16 AM
ioeric accepted this revision.Feb 6 2018, 1:42 AM

LGTM

Have we kept a lit test that uses content-length? It's unclear from the patch.

clangd/tool/ClangdMain.cpp
89

To be more specific, maybe --lit-test-mode?

This revision is now accepted and ready to land.Feb 6 2018, 1:42 AM
sammccall marked an inline comment as done.Feb 6 2018, 2:48 AM

LGTM

Have we kept a lit test that uses content-length? It's unclear from the patch.

Yes, protocol.test tests the real protocol parser. (The other tests that use this parser are are too_large, which i'll merge with protocol, and input_mirror, which i'll cut down a little bit, as followup)

clangd/tool/ClangdMain.cpp
89

changed to --lit-test. ("mode" seems redundant in a flag name?)

sammccall updated this revision to Diff 132960.Feb 6 2018, 2:48 AM
sammccall marked an inline comment as done.

-test -> -lit-test

This revision was automatically updated to reflect the committed changes.