This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Fix BITCAST lowering crash
ClosedPublic

Authored by evandro on Jan 26 2018, 1:54 PM.

Details

Summary

The data type is assumed to be a vector, but sometimes it may not be, leading to an assertion.

Add simple test-case to verify this.

Diff Detail

Repository
rL LLVM

Event Timeline

evandro created this revision.Jan 26 2018, 1:54 PM

Ping! πŸ””

Β‘Ping! πŸ””πŸ””

rengolin accepted this revision.Feb 12 2018, 3:02 AM

Sorry, I missed a lot of reviews this year (mail issues). The patch LGTM with the nit.

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
8716 β†—(On Diff #131651)

Nit: I'd add a check to this early-exit here.

This revision is now accepted and ready to land.Feb 12 2018, 3:02 AM
samparker accepted this revision.Feb 12 2018, 3:08 AM
samparker added a subscriber: samparker.

LGTM, cheers.

evandro added inline comments.Feb 15 2018, 5:32 PM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
8716 β†—(On Diff #131651)

I'm confused. Isn't this a check yet?

This revision was automatically updated to reflect the committed changes.