This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Properly handle dllimport of variables when using fast-isel
ClosedPublic

Authored by mstorsjo on Jan 26 2018, 1:35 AM.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 26 2018, 1:35 AM

LGTM, but, I think that @aemerson should give the final approval on this.

Ping @aemerson - can you give this an ack from a generic aarch64 target perspective - the windows side of it was already ok'd.

aemerson accepted this revision.Jan 30 2018, 11:10 AM

Looks fine.

This revision is now accepted and ready to land.Jan 30 2018, 11:10 AM
mstorsjo added a subscriber: hans.Jan 30 2018, 11:53 AM

@hans This would be good to have backported.

This revision was automatically updated to reflect the committed changes.
hans added a comment.Jan 31 2018, 12:59 AM

@hans This would be good to have backported.

Merged in r323852.