This is an archive of the discontinued LLVM Phabricator instance.

[MIR] Add support for addrspace in MIR
ClosedPublic

Authored by thegameg on Jan 24 2018, 1:23 PM.

Details

Summary

Add support for printing / parsing the addrspace of a MachineMemOperand.

PR35970

Diff Detail

Event Timeline

thegameg created this revision.Jan 24 2018, 1:23 PM
thegameg edited the summary of this revision. (Show Details)Jan 24 2018, 1:24 PM
MatzeB accepted this revision.Jan 24 2018, 1:30 PM
MatzeB added subscribers: arsenm, tstellar.

LGTM

(+CC AMDGPU so they can veto if they don't like the syntax)

test/CodeGen/MIR/AArch64/addrspace-memoperands.mir
26

Can you add a line that addrspace 0 is correctly parsed (and not printed)

This revision is now accepted and ready to land.Jan 24 2018, 1:30 PM
thegameg updated this revision to Diff 131339.Jan 24 2018, 1:45 PM
thegameg marked an inline comment as done.

Add test case with addrspace 0.

thegameg updated this revision to Diff 131426.Jan 25 2018, 5:57 AM

Update some more failing tests.

This revision was automatically updated to reflect the committed changes.