Page MenuHomePhabricator

asan: add kernel inline instrumentation test
ClosedPublic

Authored by andreyknvl on Jan 24 2018, 5:50 AM.

Diff Detail

Event Timeline

andreyknvl created this revision.Jan 24 2018, 5:50 AM
vsk accepted this revision.Jan 24 2018, 9:59 AM

Thanks! Let me know if you need this to be committed for you.

This revision is now accepted and ready to land.Jan 24 2018, 9:59 AM

Yes, that would be great if you commit this.

This revision was automatically updated to reflect the committed changes.

Fixed "_n" vs "N" naming and added "-asan-recover=1" flag, which is always enabled for the kernel.

Sorry, it was supposed to go on top of https://reviews.llvm.org/D42423 (which is committed now).
Anyway, I noticed an issue in naming ("loadN" is actually supposed to be "load_n") and another issue with asan flags (need "-asan-recover=1" and "noabort" suffixes).
Could you try again?

Renamed kernel_inline.ll to kernel-inline.ll

This is still not committed AFAICT.

I'll take care of it.

vsk added a comment.Feb 21 2018, 11:43 AM

@eugenis I did not see your message in time. I committed this test in r325710.

That's great, I'm still testing it in combination with https://reviews.llvm.org/D42473. It should simply go away when I do git pull.