This is an archive of the discontinued LLVM Phabricator instance.

Differential D42352

[ReleaseNotes] Mention OpenMP Tools Interface in runtime library
ClosedPublic

Authored by Hahnfeld on Jan 21 2018, 3:55 AM.

Details

Reviewers
rsmith
ABataev
hans
omalyshe
Commits
rG973f490f110a: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library
rL323179: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library
Summary

The OpenMP runtime has no dedicated Release Notes, so add it to Clang's section about OpenMP.

Diff Detail

Event Timeline

Hahnfeld created this revision.Jan 21 2018, 3:55 AM
Herald added subscribers: cfe-commits, guansong. · View Herald TranscriptJan 21 2018, 3:55 AM
hans accepted this revision.Jan 22 2018, 5:10 AM

Sounds good to me.

docs/ReleaseNotes.rst
230

Is there a missing right-angle bracket, >, here?

This revision is now accepted and ready to land.Jan 22 2018, 5:10 AM
omalyshe added inline comments.Jan 22 2018, 5:29 AM
docs/ReleaseNotes.rst
227

I'd suggest not mentioning any percentage. A note about possible performance issue due to enabling OMPT would be enough.

Hahnfeld updated this revision to Diff 130900.Jan 22 2018, 8:06 AM
Hahnfeld marked 2 inline comments as done.

Address review comments.

docs/ReleaseNotes.rst
230

Yes, and an underscore. I though I was smart enough to write reStructuredText without actually "testing" it...

omalyshe added inline comments.Jan 22 2018, 10:23 PM
docs/ReleaseNotes.rst
226

Linux*, Windows* and macOS*

Hahnfeld added inline comments.Jan 22 2018, 10:50 PM
docs/ReleaseNotes.rst
226

That's done nowhere else in Clang's documentation so I'm strongly opposed to doing it here unless you have a very good legal reason that nobody else knows about.

omalyshe added inline comments.Jan 22 2018, 10:53 PM
docs/ReleaseNotes.rst
226

I'm OK with omitting "*" but "macOS" should be definitely fixed ;)

Hahnfeld updated this revision to Diff 131004.Jan 22 2018, 10:58 PM
Hahnfeld marked 3 inline comments as done.

Fix macOS.

omalyshe accepted this revision.Jan 22 2018, 11:00 PM

LGTM

Closed by commit rL323179: [ReleaseNotes] Mention OpenMP Tools Interface in runtime library (authored by Hahnfeld). · Explain WhyJan 22 2018, 11:51 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 22 2018, 11:51 PM

Revision Contents

PathSize
docs/
8 lines

Diff 130806

docs/ReleaseNotes.rst

Show First 20 Lines • Show All 216 Lines • ▼ Show 20 Lines
- Added support for almost all target-based directives except for - Added support for almost all target-based directives except for
`#pragma omp target teams distribute parallel for [simd]`. Although, please `#pragma omp target teams distribute parallel for [simd]`. Although, please
note that `depend` clauses on target-based directives are not supported yet. note that `depend` clauses on target-based directives are not supported yet.
Clang supports offloading to X86_64, AArch64 and PPC64[LE] devices. Clang supports offloading to X86_64, AArch64 and PPC64[LE] devices.
- Added support for `reduction`-based clauses on `task`-based directives from - Added support for `reduction`-based clauses on `task`-based directives from
upcoming OpenMP 5.0. upcoming OpenMP 5.0.
- The LLVM OpenMP runtime `libomp` now supports the OpenMP Tools Interface (OMPT)
on x86, x86_64, AArch64, and PPC64 on Linux, Windows, and mac OS. Performance
omalysheUnsubmitted
Done
ReplyInline Actions

Linux*, Windows* and macOS*

omalyshe: Linux*, Windows* and macOS*
HahnfeldAuthorUnsubmitted
Done
ReplyInline Actions

That's done nowhere else in Clang's documentation so I'm strongly opposed to doing it here unless you have a very good legal reason that nobody else knows about.

Hahnfeld: That's done nowhere else in Clang's documentation so I'm strongly opposed to doing it here…
omalysheUnsubmitted
Done
ReplyInline Actions

I'm OK with omitting "*" but "macOS" should be definitely fixed ;)

omalyshe: I'm OK with omitting "*" but "macOS" should be definitely fixed ;)
measurements show that the changes result in a slowdown of at most 4 percent
omalysheUnsubmitted
Done
ReplyInline Actions

I'd suggest not mentioning any percentage. A note about possible performance issue due to enabling OMPT would be enough.

omalyshe: I'd suggest not mentioning any percentage. A note about possible performance issue due to…
in micro-benchmarks. However, if you observe a larger impact on one of your
applications, please rebuild the runtime library with `-DLIBOMP_OMPT_SUPPORT=OFF`
and file a bug at `LLVM's Bugzilla <https://bugs.llvm.org/` or send a message
hansUnsubmitted
Done
ReplyInline Actions

Is there a missing right-angle bracket, >, here?

hans: Is there a missing right-angle bracket, >, here?
HahnfeldAuthorUnsubmitted
Not Done
ReplyInline Actions

Yes, and an underscore. I though I was smart enough to write reStructuredText without actually "testing" it...

Hahnfeld: Yes, and an underscore. I though I was smart enough to write reStructuredText without actually…
to the `OpenMP development list <http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-dev>`.
Internal API Changes Internal API Changes
-------------------- --------------------
These are major API changes that have happened since the 4.0.0 release of These are major API changes that have happened since the 4.0.0 release of
Clang. If upgrading an external codebase that uses Clang as a library, Clang. If upgrading an external codebase that uses Clang as a library,
this section should help get you past the largest hurdles of upgrading. this section should help get you past the largest hurdles of upgrading.
- ... - ...
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines