Page MenuHomePhabricator

[ReleaseNotes] Mention OpenMP Tools Interface in runtime library

Authored by Hahnfeld on Jan 21 2018, 3:55 AM.



The OpenMP runtime has no dedicated Release Notes, so add it to Clang's section about OpenMP.

Diff Detail


Event Timeline

Hahnfeld created this revision.Jan 21 2018, 3:55 AM
hans accepted this revision.Jan 22 2018, 5:10 AM

Sounds good to me.

230 ↗(On Diff #130806)

Is there a missing right-angle bracket, >, here?

This revision is now accepted and ready to land.Jan 22 2018, 5:10 AM
omalyshe added inline comments.Jan 22 2018, 5:29 AM
227 ↗(On Diff #130806)

I'd suggest not mentioning any percentage. A note about possible performance issue due to enabling OMPT would be enough.

Hahnfeld updated this revision to Diff 130900.Jan 22 2018, 8:06 AM
Hahnfeld marked 2 inline comments as done.

Address review comments.

230 ↗(On Diff #130806)

Yes, and an underscore. I though I was smart enough to write reStructuredText without actually "testing" it...

omalyshe added inline comments.Jan 22 2018, 10:23 PM
226 ↗(On Diff #130900)

Linux*, Windows* and macOS*

Hahnfeld added inline comments.Jan 22 2018, 10:50 PM
226 ↗(On Diff #130900)

That's done nowhere else in Clang's documentation so I'm strongly opposed to doing it here unless you have a very good legal reason that nobody else knows about.

omalyshe added inline comments.Jan 22 2018, 10:53 PM
226 ↗(On Diff #130900)

I'm OK with omitting "*" but "macOS" should be definitely fixed ;)

Hahnfeld updated this revision to Diff 131004.Jan 22 2018, 10:58 PM
Hahnfeld marked 3 inline comments as done.

Fix macOS.

This revision was automatically updated to reflect the committed changes.