This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Remove custom handling for undefined entry. NFC
ClosedPublic

Authored by sbc100 on Jan 19 2018, 3:09 PM.

Details

Summary

Handle undefined entry just like any other symbols.

This code was needed back when we were not able to write
out the synthetic symbol for main.

Add tests to make sure we can handle this now.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Jan 19 2018, 3:09 PM
sbc100 edited the summary of this revision. (Show Details)Jan 19 2018, 3:09 PM
ruiu accepted this revision.Jan 19 2018, 3:12 PM

LGTM

This revision is now accepted and ready to land.Jan 19 2018, 3:12 PM
sbc100 retitled this revision from [WebAssembly] Remove custom handling for undefined entry to [WebAssembly] Remove custom handling for undefined entry. NFC.Jan 19 2018, 3:30 PM
ncw accepted this revision.Jan 19 2018, 4:43 PM

LGTM

This revision was automatically updated to reflect the committed changes.