This is an archive of the discontinued LLVM Phabricator instance.

[Analysis] Disable exp/exp2/pow finite lib calls on Android with -ffast-math.
ClosedPublic

Authored by minseong.kim on Jan 19 2018, 2:55 AM.

Details

Summary

Since r322087, glibc's finite lib calls are generated when possible.
However, glibc is not supported on Android. Therefore this change
enables llvm to finely distinguish between linux and Android for
unsupported library calls. The change also include some regression
tests.

Diff Detail

Repository
rL LLVM

Event Timeline

minseong.kim created this revision.Jan 19 2018, 2:55 AM
minseong.kim removed a subscriber: srhines.
srhines accepted this revision.Jan 22 2018, 5:07 PM
srhines added subscribers: chh, kongyi.

Thanks for fixing this. We were just starting to encounter build issues with the _finite functions, and wondering about the best way to approach it. This is very clean.

This revision is now accepted and ready to land.Jan 22 2018, 5:08 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the review.