Page MenuHomePhabricator

minseong.kim (MinSeong Kim)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2015, 2:48 AM (358 w, 6 d)

Recent Activity

Jan 30 2018

minseong.kim added inline comments to D42668: [Analysis] Disable calls to *_finite and other glibc-only functions on Android..
Jan 30 2018, 4:11 AM

Jan 23 2018

minseong.kim added a comment to D42288: [Analysis] Disable exp/exp2/pow finite lib calls on Android with -ffast-math..

Thanks for the review.

Jan 23 2018, 4:08 AM

Jan 19 2018

minseong.kim added reviewers for D42288: [Analysis] Disable exp/exp2/pow finite lib calls on Android with -ffast-math.: srhines, pirama.
Jan 19 2018, 3:00 AM
minseong.kim created D42288: [Analysis] Disable exp/exp2/pow finite lib calls on Android with -ffast-math..
Jan 19 2018, 2:56 AM

Sep 7 2017

minseong.kim updated the diff for D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

Re-uploading the patch, removing debug messages accidentally included in the patch.

Sep 7 2017, 5:18 AM

Sep 6 2017

minseong.kim updated the diff for D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

I have updated the diff.

Sep 6 2017, 8:56 PM
minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

@hintonda, Absolutely. Incorporating @modocache's module changes into the version in AddLLVM.cmake would solve the current version display issue for repo and do not affect the process of other version control systems (e.g. git, git-svn, svn, and git submodule).

Sep 6 2017, 5:14 PM
minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

Using using find_first_existing_file in ADDLLVM.cmake solves the cases with repo in conjunction with D35532. However, I am not sure it can handle @modocache's git submodule cases (D34955).

Sep 6 2017, 4:28 PM
minseong.kim retitled D35533: [Basic] Update CMakeLists.txt to handle Repo with git from [Basic] Update CMakeLists.txt to handle Repo to [Basic] Update CMakeLists.txt to handle Repo with git.
Sep 6 2017, 2:33 AM
minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

I have updated the description with a hope for it to be more descriptive.

Sep 6 2017, 2:33 AM

Sep 5 2017

minseong.kim added a comment to D35532: [CMake] Update GetSVN.cmake to handle Repo.

I have updated the description with a hope for it to be more descriptive.
Kindly ping~

Sep 5 2017, 3:53 AM
minseong.kim updated the summary of D35532: [CMake] Update GetSVN.cmake to handle Repo.
Sep 5 2017, 3:52 AM

Aug 27 2017

minseong.kim accepted D36971: [CMAKE] Move version control macros to AddLLVM.cmake so they can be reused by clang, etc..

I have tested this patch with git, git-svn, svn and repo. It is working as expected with clang's lib/Basic/CMakeLists.txt.
LGTM.

Aug 27 2017, 10:37 PM

Aug 26 2017

minseong.kim added a comment to D36971: [CMAKE] Move version control macros to AddLLVM.cmake so they can be reused by clang, etc..

I just checked that this patch is working correctly from clang. I am just wondering if there is a possibility of using clang only without llvm. If this is the case, clang might need its own version control macros ? Or no such case.

Aug 26 2017, 2:48 AM

Aug 22 2017

minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

I will test your patch with repo. Thanks for your time and efforts, @hintonda.

Aug 22 2017, 7:51 PM

Aug 11 2017

minseong.kim added a comment to D35532: [CMake] Update GetSVN.cmake to handle Repo.

kindly ping~

Aug 11 2017, 1:02 AM
minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

kindly ping~

Aug 11 2017, 1:02 AM

Jul 20 2017

minseong.kim updated the summary of D35532: [CMake] Update GetSVN.cmake to handle Repo.
Jul 20 2017, 2:22 AM

Jul 19 2017

minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

Thanks @jordan_rose @modocache @hintonda for your time and efforts.
This patch does regenerate the version control info correctly (SVNVersion.inc) every time I re-make clang. Probably I am missing something here.
Could you please be more specific and share your idea about "adding all of these as dependencies" to force reconfigure revision info whenever new commits added.
I will gladly change this patch accordingly.

Jul 19 2017, 5:52 PM
minseong.kim added a comment to D35533: [Basic] Update CMakeLists.txt to handle Repo with git.

Thanks for the reviewing this patch. Please correct if I am wrong.

Jul 19 2017, 7:16 AM

Jul 18 2017

minseong.kim created D35533: [Basic] Update CMakeLists.txt to handle Repo with git.
Jul 18 2017, 12:54 AM
minseong.kim added reviewers for D35532: [CMake] Update GetSVN.cmake to handle Repo: llvm-commits, probinson.
Jul 18 2017, 12:45 AM
minseong.kim created D35532: [CMake] Update GetSVN.cmake to handle Repo.
Jul 18 2017, 12:42 AM