This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] Build runtime library with -fPIC, not -fPIE.
ClosedPublic

Authored by eugenis on Jan 16 2018, 11:10 AM.

Reviewers

Commits

Summary

-fPIE can not be used when building a shared library.

Build Status

Buildable 13876
Build 13876: arc lint + arc unit

LGTM

This revision is now accepted and ready to land.Jan 16 2018, 11:14 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

lib/

hwasan/

2 lines

Show All 11 Lines	set(HWASAN_RTL_SOURCES
)		)

set(HWASAN_RTL_CXX_SOURCES		set(HWASAN_RTL_CXX_SOURCES
hwasan_new_delete.cc)		hwasan_new_delete.cc)


set(HWASAN_RTL_CFLAGS ${SANITIZER_COMMON_CFLAGS})		set(HWASAN_RTL_CFLAGS ${SANITIZER_COMMON_CFLAGS})
append_rtti_flag(OFF HWASAN_RTL_CFLAGS)		append_rtti_flag(OFF HWASAN_RTL_CFLAGS)
append_list_if(COMPILER_RT_HAS_FPIE_FLAG -fPIE HWASAN_RTL_CFLAGS)		append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC HWASAN_RTL_CFLAGS)
# Prevent clang from generating libc calls.		# Prevent clang from generating libc calls.
append_list_if(COMPILER_RT_HAS_FFREESTANDING_FLAG -ffreestanding HWASAN_RTL_CFLAGS)		append_list_if(COMPILER_RT_HAS_FFREESTANDING_FLAG -ffreestanding HWASAN_RTL_CFLAGS)

set(HWASAN_DYNAMIC_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})		set(HWASAN_DYNAMIC_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})

if(ANDROID)		if(ANDROID)
# On Android, -z global does not do what it is documented to do.		# On Android, -z global does not do what it is documented to do.
# On Android, -z global moves the library ahead in the lookup order,		# On Android, -z global moves the library ahead in the lookup order,
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines