Page MenuHomePhabricator

[AMDGPU][MC][GFX9] Enable inline constants for SDWA
ClosedPublic

Authored by dp on Jan 15 2018, 3:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.Jan 15 2018, 3:53 AM
artem.tamazov accepted this revision.Jan 15 2018, 7:01 AM

If possible, please add some negative test(s), i.e. SDWA with non-inlineable constant(s). See also style-related recommendation. Otherwise fine.

lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
758 ↗(On Diff #129828)

Modifying the function parameter may lead to coding errors during further evolvement of the function. I recommend introducing a new const unsigned var.

This revision is now accepted and ready to land.Jan 15 2018, 7:01 AM
This revision was automatically updated to reflect the committed changes.