Reland "Make TracePcGuardController linker-initialized"

[phosek]

Summary

This broke check-tsan because of linter issues.

[mcgrathr]

clang-format and lib/sanitizer_common/scripts/cpplint.py disagree about whitespace before braces.

[mcgrathr]

I wonder if cpplint.py is worthwhile any more. Perhaps it should be replaced by a check that clang-format doesn't decide to change anything.

[phosek]

@kcc @vitalybuka lib/sanitizer_common/scripts/cpplint.py and clang-format seem to disagree on formatting of static initializers which is breaking the build. It's likely that the version that's in tree doesn't even support static initializers. I tried to replace lib/sanitizer_common/scripts/cpplint.py with the latest version from https://github.com/cpplint/cpplint which resolves this issue but starts throwing errors for other files in compiler-rt. Do you have any suggestion/opinion on what to do about this?

[vitalybuka]

In D42022#975484, @phosek wrote:

@kcc @vitalybuka lib/sanitizer_common/scripts/cpplint.py and clang-format seem to disagree on formatting of static initializers which is breaking the build. It's likely that the version that's in tree doesn't even support static initializers. I tried to replace lib/sanitizer_common/scripts/cpplint.py with the latest version from https://github.com/cpplint/cpplint which resolves this issue but starts throwing errors for other files in compiler-rt. Do you have any suggestion/opinion on what to do about this?

Yeah, it's know and a little bit annoying issue. I've filed https://github.com/google/sanitizers/issues/906 We need to do something about that.
For now you can just follow whatever it's asking for, even if it's conflicts for clang-format. If it gets very ugly or impossible just put // NOLINT

lib/sanitizer_common/sanitizer_coverage_fuchsia.cc

116

BlockingMutex setup_lock_ = {LINKER_INITIALIZED};
uptr *array_ = nullptr;
u32 next_index_ = 0;
zx_handle_t vmo _ = {};
char vmo_name_[ZX_MAX_NAME_LEN] = {};

lib/sanitizer_common/sanitizer_coverage_fuchsia.cc

 // TODO(mcgrathr): Move the constant into a header shared with other impls.
 constexpr u64 Magic64 = 0xC0BFFFFFFFFFFF64ULL;
 static_assert(SANITIZER_WORDSIZE == 64, "Fuchsia is always LP64");
 
 constexpr const char kSancovSinkName[] = "sancov";
 
 // Collects trace-pc guard coverage.
 // This class relies on zero-initialization.
-class TracePcGuardController {
+class TracePcGuardController final {
  public:
   // For each PC location being tracked, there is a u32 reserved in global
   // data called the "guard".  At startup, we assign each guard slot a
   // unique index into the big results array.  Later during runtime, the
   // first call to TracePcGuard (below) will store the corresponding PC at
   // that index in the array.  (Each later call with the same guard slot is
   // presumed to be from the same PC.)  Then it clears the guard slot back
   // to zero, which tells the compiler not to bother calling in again.  At

 
  private:
   // We map in the largest possible view into the VMO: one word
   // for every possible 32-bit index value.  This avoids the need
   // to change the mapping when increasing the size of the VMO.
   // We can always spare the 32G of address space.
   static constexpr size_t MappingSize = sizeof(uptr) << 32;
 
-  BlockingMutex setup_lock_;
-  uptr *array_;
-  u32 next_index_;
-  zx_handle_t vmo_;
-  char vmo_name_[ZX_MAX_NAME_LEN];
+  BlockingMutex setup_lock_ {LINKER_INITIALIZED};
+  uptr *array_ {};
+  u32 next_index_ {};
+  zx_handle_t vmo _ {};
+  char vmo_name_[ZX_MAX_NAME_LEN] {};
 
   size_t DataSize() const { return next_index_ * sizeof(uintptr_t); }
 
   u32 Setup(u32 num_guards) {
     BlockingMutexLock locked(&setup_lock_);
     DCHECK(common_flags()->coverage);
 
     if (next_index_ == 0) {