Reland "Make TracePcGuardController linker-initialized"
Needs ReviewPublic

Authored by phosek on Fri, Jan 12, 5:03 PM.

Details

Summary

This broke check-tsan because of linter issues.

Diff Detail

phosek created this revision.Fri, Jan 12, 5:03 PM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. ยท View Herald TranscriptFri, Jan 12, 5:03 PM

clang-format and lib/sanitizer_common/scripts/cpplint.py disagree about whitespace before braces.

mcgrathr added a project: Restricted Project.Fri, Jan 12, 5:07 PM

I wonder if cpplint.py is worthwhile any more. Perhaps it should be replaced by a check that clang-format doesn't decide to change anything.

@kcc @vitalybuka lib/sanitizer_common/scripts/cpplint.py and clang-format seem to disagree on formatting of static initializers which is breaking the build. It's likely that the version that's in tree doesn't even support static initializers. I tried to replace lib/sanitizer_common/scripts/cpplint.py with the latest version from https://github.com/cpplint/cpplint which resolves this issue but starts throwing errors for other files in compiler-rt. Do you have any suggestion/opinion on what to do about this?