This is an archive of the discontinued LLVM Phabricator instance.

[TSan][MIPS] Expand mips sanitizer memory space to include shadow mappings of low addresses
ClosedPublic

Authored by mstojanovic on Jan 5 2018, 10:00 AM.

Details

Summary

MemToShadowImpl() maps lower addresses to a memory space out of sanitizers range. The simplest example is address 0 which is mapped to 0x2000000000 but since

static const uptr kShadowBeg     = 0x2400000000ull;

accessing the address during tsan execution will lead to a segmentation fault.

This patch expands the range used by the sanitizer and ensures that 1/8 of the maximum valid address in the virtual address spaces is used for shadow memory.

Diff Detail

Event Timeline

mstojanovic created this revision.Jan 5 2018, 10:00 AM
sdardis accepted this revision.Jan 19 2018, 7:01 AM

LGTM.

This revision is now accepted and ready to land.Jan 19 2018, 7:01 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 19 2018, 4:08 PM