Improves the code generation for v4f16 FCMP instructions when FullFP16 is not supported by generating FCTVL(s) rather than a longer series of FCVTs.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Thanks, looks good to me. Just a few nits inlined, no need for another review.
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
7296 ↗ | (On Diff #128760) | Nit: perhaps a "TODO remark" here that v8f16 could be optimised as well but is a bit more complicated? |
7303 ↗ | (On Diff #128760) | Nit: newline not necessary? |
7305 ↗ | (On Diff #128760) | Coding style nit: you don't need the brackets for the else-clause (you can check the coding style with clang-format) |