This is an archive of the discontinued LLVM Phabricator instance.

Differential D41194

Add missing reference to lldCommon in MinGW/CMakeLists.txt
ClosedPublic

Authored by sbc100 on Dec 13 2017, 12:37 PM.

Details

Reviewers
ruiu
Commits
rG51d7798237ba: Add missing reference to lldCommon in MinGW/CMakeLists.txt
rLLD320610: Add missing reference to lldCommon in MinGW/CMakeLists.txt
rL320610: Add missing reference to lldCommon in MinGW/CMakeLists.txt
Summary

Without this the LLVM_BUILD_LLVM_DYLIB+DLLVM_LINK_LLVM_DYLIB build
break.

Also remove unneeded lldCore from wasm/CMakeLists.txt

Diff Detail

Event Timeline

sbc100 created this revision.Dec 13 2017, 12:37 PM
Herald added subscribers: llvm-commits, sunfish, aheejin, mgorny. · View Herald TranscriptDec 13 2017, 12:37 PM
Harbormaster completed remote builds in B13076: Diff 126809.Dec 13 2017, 12:37 PM
sbc100 edited the summary of this revision. (Show Details)Dec 13 2017, 12:38 PM
sbc100 added a reviewer: ruiu.
ruiu accepted this revision.Dec 13 2017, 12:38 PM

LGTM

This revision is now accepted and ready to land.Dec 13 2017, 12:38 PM
Closed by commit rL320610: Add missing reference to lldCommon in MinGW/CMakeLists.txt (authored by sbc). · Explain WhyDec 13 2017, 12:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MinGW/
1 line
wasm/
1 line

Diff 126809

MinGW/CMakeLists.txt

Show All 9 Linesadd_lld_library(lldMinGW
Driver.cpp Driver.cpp
LINK_COMPONENTS LINK_COMPONENTS
Option Option
Support Support
LINK_LIBS LINK_LIBS
lldCOFF lldCOFF
lldCommon
DEPENDS DEPENDS
MinGWOptionsTableGen MinGWOptionsTableGen
${tablegen_deps} ${tablegen_deps}
) )

wasm/CMakeLists.txt

Show All 17 Linesadd_lld_library(lldWasm
Core Core
Demangle Demangle
Object Object
Option Option
Support Support
LINK_LIBS LINK_LIBS
lldCommon lldCommon
lldCore
) )