This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] Inline instrumentation & fixed shadow.
ClosedPublic

Authored by eugenis on Dec 12 2017, 2:53 PM.

Event Timeline

eugenis created this revision.Dec 12 2017, 2:53 PM
kcc accepted this revision.Dec 12 2017, 2:58 PM

LGTM with one optional question.

compiler-rt/lib/hwasan/hwasan_linux.cc
125

Do you still want to keep it?

This revision is now accepted and ready to land.Dec 12 2017, 2:58 PM
eugenis updated this revision to Diff 126650.Dec 12 2017, 5:00 PM

Removed unused variable.

eugenis added inline comments.Dec 12 2017, 5:01 PM
compiler-rt/lib/hwasan/hwasan_linux.cc
125

you are right, there is no point in keeping it

eugenis updated this revision to Diff 126659.Dec 12 2017, 5:16 PM

update hwasan tests

This revision was automatically updated to reflect the committed changes.