This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] adjust cppcoreguidelines-owning-memory documentation
ClosedPublic

Authored by JonasToth on Dec 5 2017, 2:40 AM.

Details

Summary

A user of the check opened a bugreport and reported that std::exchange
triggers a false positive. I adjusted the doc to include a list of known
(std) constructs that do trigger the issue with templates forgetting the
type alias.

Diff Detail

Repository
rL LLVM

Event Timeline

JonasToth created this revision.Dec 5 2017, 2:40 AM
aaron.ballman accepted this revision.Dec 5 2017, 8:04 AM

This is reasonable, though if the list starts getting longer, we should consider trying to fix the bug rather than enumerate them.

docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst
115 ↗(On Diff #125486)

Add a colon after are.

This revision is now accepted and ready to land.Dec 5 2017, 8:04 AM
JonasToth updated this revision to Diff 125536.Dec 5 2017, 8:35 AM
  • [Fix] typo
This revision was automatically updated to reflect the committed changes.