This is an archive of the discontinued LLVM Phabricator instance.

Differential D40589

Add libstd++-4.8 exceptions to ubsan_blacklist.txt
ClosedPublic

Authored by sbc100 on Nov 28 2017, 4:31 PM.

Details

Reviewers
vitalybuka
Commits
rG51d90c8c6bc0: Add libstd++-4.8 exceptions to ubsan_blacklist.txt
rL319353: Add libstd++-4.8 exceptions to ubsan_blacklist.txt

Diff Detail

Event Timeline

sbc100 created this revision.Nov 28 2017, 4:31 PM
Herald added a subscriber: aheejin. · View Herald TranscriptNov 28 2017, 4:31 PM
Harbormaster completed remote builds in B12574: Diff 124664.Nov 28 2017, 4:31 PM
sbc100 added a reviewer: vitalybuka.Nov 28 2017, 4:33 PM
sbc100 added a subscriber: llvm-commits.
sbc100 updated this revision to Diff 124668.Nov 28 2017, 4:47 PM
  • add bug ref
sbc100 added subscribers: dschuff, binji.Nov 28 2017, 4:58 PM
vitalybuka accepted this revision.Nov 29 2017, 11:27 AM
This revision is now accepted and ready to land.Nov 29 2017, 11:27 AM
Closed by commit rL319353: Add libstd++-4.8 exceptions to ubsan_blacklist.txt (authored by sbc). · Explain WhyNov 29 2017, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
utils/
sanitizers/
5 lines

Diff 124668

utils/sanitizers/ubsan_blacklist.txt

# This blacklist should be applied when LLVM is built # This blacklist should be applied when LLVM is built
# with -fsanitize=undefined instrumentation. It exists # with -fsanitize=undefined instrumentation. It exists
# because libstdc++ has some undefined behavior issues # because libstdc++ has some undefined behavior issues
# in some of the headers, in particular, stl_tree.h. # in some of the headers, in particular, stl_tree.h.
# upcast of address with insufficient space for an object of type std::_Rb_tree_node<...> # upcast of address with insufficient space for an object of type std::_Rb_tree_node<...>
src:*bits/stl_tree.h src:*bits/stl_tree.h
# libstdc++ 4.8 creates a null reference when calling
# data() on an empty vector: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59829
src:*bits/stl_iterator.h
src:*bits/stl_vector.h