Currently we don't generate the scheduler comments for instructions inside inline asm. The patch fixes that and address PR35162.
Details
Diff Detail
Event Timeline
Overall, the patch looks good to me.
I made some minor comments below.
include/llvm/MC/MCParser/MCAsmParser.h | ||
---|---|---|
132 | Comments should end with a period. I noticed the same mistake in AsmPrinter.h. | |
135–136 | Unrelated to your code review. However, this comment should be associated to field 'HadError' at line 130. I think this should be fixed. | |
169 | I suggest to rename enablePrintSchedInfo() to shouldPrintSchedInfo(). | |
lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp | ||
198 | Add a /* unused */ for the bool param. | |
1047–1049 | I suggest to change EnableSchedInfo to just PrintSchedInfo (or PrintSchedInfoEnabled). | |
1051–1054 | Same. | |
lib/Target/X86/AsmParser/X86AsmInstrumentation.h | ||
45–47 | I suggest to change EnableSchedInfo to just PrintSchedInfo (or PrintSchedInfoEnabled). | |
58–60 | Same. | |
lib/Target/X86/AsmParser/X86AsmParser.cpp | ||
2704 | I suggest to rename enablePrintSchedInfo() to shouldPrintSchedInfo(). |
Comments should end with a period. I noticed the same mistake in AsmPrinter.h.