This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX9][disassembler] Corrected decoding of op_sel_hi for v_mad_mix*
ClosedPublic

Authored by dp on Nov 1 2017, 7:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

dp created this revision.Nov 1 2017, 7:30 AM
arsenm added inline comments.Nov 5 2017, 3:57 PM
lib/Target/AMDGPU/SIInstrFormats.td
118–119 ↗(On Diff #121125)

If you're going to introduce this field, it should probably be consistently used. I think I did something else when changing the default printed value in the InstPrinter.

dp marked an inline comment as done.Nov 7 2017, 5:52 AM
dp added inline comments.
lib/Target/AMDGPU/SIInstrFormats.td
118–119 ↗(On Diff #121125)

This field was introduced for InstPrinter to distinguish between packed and non-packed instructions. Is there another simple way doing it? I do not see any.

Or do you suggest correcting AsmParser to use this new field instead of VOP3P_NotPacked?

dp updated this revision to Diff 122078.Nov 8 2017, 5:58 AM
dp marked an inline comment as done.

Corrected and simplified as suggested by Matt

arsenm accepted this revision.Nov 13 2017, 3:28 PM

LGTM

This revision is now accepted and ready to land.Nov 13 2017, 3:28 PM
This revision was automatically updated to reflect the committed changes.