This is an archive of the discontinued LLVM Phabricator instance.

Differential D39250

Fix LLVM_LINK_LLVM_DYLIB=On build of llvm-cfi-verify
ClosedPublic

Authored by sbc100 on Oct 24 2017, 11:13 AM.

Details

Reviewers
skatkov
dschuff
Commits
rGdabd5be42dd7: Fix LLVM_LINK_LLVM_DYLIB=On build of llvm-cfi-verify
rL316493: Fix LLVM_LINK_LLVM_DYLIB=On build of llvm-cfi-verify
Summary

IIUC CFIVerify is a static library that is shared between just the tool and
the unittest for the tool.
As such it should not be linked in the libLLVM and not a "component."

See rL316059 and rL316372 and rL316422

Diff Detail

Event Timeline

sbc100 created this revision.Oct 24 2017, 11:13 AM
Harbormaster completed remote builds in B11442: Diff 120103.Oct 24 2017, 11:13 AM
Herald added subscribers: aheejin, mgorny. · View Herald TranscriptOct 24 2017, 11:13 AM
sbc100 edited the summary of this revision. (Show Details)Oct 24 2017, 11:16 AM
sbc100 edited the summary of this revision. (Show Details)
sbc100 added subscribers: llvm-commits, dschuff.
sbc100 added a reviewer: skatkov.Oct 24 2017, 11:33 AM
dschuff added a comment.Oct 24 2017, 12:28 PM

Can you add to the commit description that this fixes the build with -DLLVM_LINK_LLVM_DYLIB=ON?

dschuff accepted this revision.Oct 24 2017, 12:28 PM
This revision is now accepted and ready to land.Oct 24 2017, 12:28 PM
dschuff added a comment.Oct 24 2017, 12:29 PM

oh wait it's in the subject line... just ignore me :D

Closed by commit rL316493: Fix LLVM_LINK_LLVM_DYLIB=On build of llvm-cfi-verify (authored by sbc). · Explain WhyOct 24 2017, 1:21 PM
This revision was automatically updated to reflect the committed changes.
skatkov edited edge metadata.Oct 24 2017, 7:49 PM

Thank you for doing this!

Revision Contents

PathSize
tools/
llvm-cfi-verify/
2 lines
unittests/
tools/
llvm-cfi-verify/
1 line

Diff 120103

tools/llvm-cfi-verify/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
AllTargetsAsmPrinters AllTargetsAsmPrinters
AllTargetsAsmParsers AllTargetsAsmParsers
AllTargetsDescs AllTargetsDescs
AllTargetsDisassemblers AllTargetsDisassemblers
AllTargetsInfos AllTargetsInfos
CFIVerify
MC MC
MCParser MCParser
Object Object
Support Support
) )
add_llvm_tool(llvm-cfi-verify add_llvm_tool(llvm-cfi-verify
llvm-cfi-verify.cpp) llvm-cfi-verify.cpp)
add_subdirectory(lib) add_subdirectory(lib)
target_link_libraries(llvm-cfi-verify LLVMCFIVerify)

unittests/tools/llvm-cfi-verify/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
AllTargetsAsmPrinters AllTargetsAsmPrinters
AllTargetsAsmParsers AllTargetsAsmParsers
AllTargetsDescs AllTargetsDescs
AllTargetsDisassemblers AllTargetsDisassemblers
AllTargetsInfos AllTargetsInfos
CFIVerify
MC MC
MCParser MCParser
Object Object
Support Support
) )
add_llvm_unittest(CFIVerifyTests add_llvm_unittest(CFIVerifyTests
FileAnalysis.cpp FileAnalysis.cpp
GraphBuilder.cpp) GraphBuilder.cpp)
target_link_libraries(CFIVerifyTests LLVMCFIVerify) target_link_libraries(CFIVerifyTests LLVMCFIVerify)