This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] MC: Fix crash when -g specified
ClosedPublic

Authored by sbc100 on Oct 18 2017, 3:42 PM.

Details

Summary

At this point we don't output any debug sections or their relocations.

Event Timeline

sbc100 created this revision.Oct 18 2017, 3:42 PM
sbc100 retitled this revision from [WebAssembly] MC: Fix crash when -g specified. At this point we don't output any debug sections or thier relocations. to [WebAssembly] MC: Fix crash when -g specified.At this point we don't output any debug sections or thierrelocations..Oct 18 2017, 3:42 PM
sbc100 added reviewers: sunfish, dschuff.
sbc100 retitled this revision from [WebAssembly] MC: Fix crash when -g specified.At this point we don't output any debug sections or thierrelocations. to [WebAssembly] MC: Fix crash when -g specified.
sbc100 edited the summary of this revision. (Show Details)
sbc100 edited the summary of this revision. (Show Details)
sbc100 added a subscriber: llvm-commits.
sbc100 updated this revision to Diff 119618.Oct 19 2017, 2:34 PM
  • simplify
sbc100 updated this revision to Diff 119621.Oct 19 2017, 2:43 PM
  • cleanup
sbc100 updated this revision to Diff 119670.Oct 20 2017, 10:55 AM
  • simplify
  • cleanup
  • fix musl build
dschuff accepted this revision.Oct 20 2017, 1:37 PM

LGTM, assuming I am correct in thinking that this will not affect the current wasm-elf assembly output (which does emit .loc directives).

This revision is now accepted and ready to land.Oct 20 2017, 1:37 PM
This revision was automatically updated to reflect the committed changes.