This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add support for isa version note
ClosedPublic

Authored by kzhuravl on Oct 10 2017, 11:31 AM.

Details

Summary
  • Emit NT_AMD_AMDGPU_ISA
  • Add assembler parsing for isa version directive
    • If isa version directive does not match command line arguments, then return error

Diff Detail

Event Timeline

kzhuravl created this revision.Oct 10 2017, 11:31 AM
arsenm added inline comments.Oct 10 2017, 3:46 PM
lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
59

I would expect the API for this to be to pass in the raw_ostream&

test/CodeGen/AMDGPU/elf-notes.ll
1

Move this last

kzhuravl updated this revision to Diff 118836.Oct 12 2017, 1:29 PM
kzhuravl marked 2 inline comments as done.
kzhuravl added a reviewer: arsenm.

Address review feedback.

t-tye accepted this revision.Oct 13 2017, 5:01 PM

LGTM

This revision is now accepted and ready to land.Oct 13 2017, 5:01 PM
This revision was automatically updated to reflect the committed changes.