[ELF][MIPS] Check for overflow when writing R_MIPS_CALL16 and R_MIPS_TLS_GOTTPREL

[arichardson]

Summary

These are 16 bit relocations and not part of a HI/LO pair so we need to
check that they don't overflow.

[sdardis]

+llvm-commits

Patches have to be CC'd to the relevant commits list.

[arichardson]

Added a test case.

I noticed that test case no longer works with https://reviews.llvm.org/D31528 (Multi-GOT) and I'm not sure how to create one that works with it.

[atanasyan]

LGTM

I think it will be impossible to write a test case for this change when multi-GOT is implemented. The only option is to implement a "debug" command line option for disabling multi-GOT. Additional flag is redundant, but my patch has mips-got-size flag. I consider to treat a zero argument of this flag as a special value.

lld/trunk/ELF/Arch/Mips.cpp

void MIPS<ELFT>::relocateOne(uint8_t *Loc, uint32_t Type, uint64_t Val) const {
   case R_MICROMIPS_GOT16:
     if (Config->Relocatable) {
       writeMicroRelocation32<E>(Loc, Val + 0x8000, 16, 16);
     } else {
       checkInt<16>(Loc, Val, Type);
       writeMicroRelocation32<E>(Loc, Val, 16, 0);
     }
     break;
+  case R_MIPS_CALL16:
   case R_MIPS_GOT_DISP:
   case R_MIPS_GOT_PAGE:
   case R_MIPS_GPREL16:
   case R_MIPS_TLS_GD:
+  case R_MIPS_TLS_GOTTPREL:
   case R_MIPS_TLS_LDM:
     checkInt<16>(Loc, Val, Type);
     LLVM_FALLTHROUGH;
-  case R_MIPS_CALL16:
   case R_MIPS_CALL_LO16:
   case R_MIPS_GOT_LO16:
   case R_MIPS_GOT_OFST:
   case R_MIPS_LO16:
   case R_MIPS_PCLO16:
   case R_MIPS_TLS_DTPREL_LO16:
-  case R_MIPS_TLS_GOTTPREL:
   case R_MIPS_TLS_TPREL_LO16:
     writeRelocation<E>(Loc, Val, 16, 0);
     break;
   case R_MICROMIPS_GOT_DISP:
   case R_MICROMIPS_GOT_PAGE:
   case R_MICROMIPS_GPREL16:
   case R_MICROMIPS_TLS_GD:
   case R_MICROMIPS_TLS_LDM:

lld/trunk/test/ELF/mips-out-of-bounds-call16-reloc.s

+# Check that we create an error on an out-of-bounds R_MIPS_CALL_16
+
+# REQUIRES: mips
+# RUN: llvm-mc -filetype=obj -triple=mips64-unknown-linux %s -o %t1.o
+# RUN: not ld.lld %t1.o -o %t.exe 2>&1 | FileCheck %s
+
+# CHECK: relocation R_MIPS_CALL16 out of range
+
+.macro generate_values
+  .irp i, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+    .irp j, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+      .irp k, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+        .irp l, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+          .text
+          .globl sym_\i\j\k\l
+          sym_\i\j\k\l:
+          nop
+          lw $25,%call16(sym_\i\j\k\l)($28)
+        .endr
+      .endr
+    .endr
+  .endr
+.endm
+
+generate_values
+
+.globl __start
+__start:
+  nop