Adding missing test cases for dext, dextm, dextu, dins, dinsu instructions to test/MC/Mips/mips64r{2|6}/valid.s
Depends on D37683
Paths
| Differential D37741
[mips] Adding test cases for dext and dins family of instructions ClosedPublic Authored by abeserminji on Sep 12 2017, 6:40 AM.
Details Summary Adding missing test cases for dext, dextm, dextu, dins, dinsu instructions to test/MC/Mips/mips64r{2|6}/valid.s Depends on D37683
Diff Detail
Event Timelineabeserminji retitled this revision from Adding test cases for dext and dins family of instructions to [mips] Adding test cases for dext and dins family of instructions .Sep 12 2017, 6:43 AM Comment Actions Can you also add the corresponding invalid cases to test/MC/Mips/mips64r{2|6}/invalid.s ? We need to specifically check the various constraints on the size, position and size + position for those instructions. Thanks, Comment Actions I noticed that you have submitted a patch D34887 that covers cases with invalid size+position for dext* and dins* instructions. So I guess I'll be skipping these tests here. This revision is now accepted and ready to land.Sep 13 2017, 7:37 AM Comment Actions Let me just clarify myself: I will do the pos and size tests in test/MC/Mips/mips64r{2|6}/invalid.s but I will skip size+pos tests. Closed by commit rL314503: [mips] Add test cases for dext/dins family of instructions (authored by abeserminji). · Explain WhySep 29 2017, 2:55 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 117111 llvm/trunk/test/MC/Mips/mips64r2/invalid.s
llvm/trunk/test/MC/Mips/mips64r2/valid.s
llvm/trunk/test/MC/Mips/mips64r6/invalid.s
llvm/trunk/test/MC/Mips/mips64r6/valid.s
|